General warnings and tests cleanup #3107
Conversation
… and explicitly specify complete concurrency checking.
…lisions between tests when running tests in parallel, silence warnings when building with the nightlies.
There was a problem hiding this comment.
There are still some warnings on linux, see the gql build log in CI.
Most of them are Date/Data warnings which I wouldn't bother fixing as Franz's changes should "take effect" sooner or later, but there are some NIOLockedValueBox warnings that can be resolved.
| @@ -130,6 +130,7 @@ extension Request.Body: AsyncSequence { | |||
| failureType: Error.self, | |||
| backPressureStrategy: NIOAsyncSequenceProducerBackPressureStrategies | |||
| .HighLowWatermark(lowWatermark: 5, highWatermark: 20), | |||
| finishOnDeinit: true, | |||
There was a problem hiding this comment.
I wonder if this fixes our crash on connection close issue
There was a problem hiding this comment.
Doubt it - finishOnDeinit: true was previously the default behavior anyway, they just force you to state it explicitly now.
There was a problem hiding this comment.
I'd've probably changed it up if I'd felt like digging into the appropriate semantics, but I had other things to figure out, as it happened 😆
|
@MahdiBM those should all be fixed in 5.9 - the only one that's left is the |
|
O right, I was wondering why they aren't fixed yet. I forgot the gql CI stil uses 5.8 because 5.9 was having problems with gql. |
|
These changes are now available in 4.87.1 |
* main: (44 commits) Update routing-kit version (vapor#3131) Use `singleton` `EventLoopGroup` (vapor#3128) Additional tests fixes Fix for Apple changing things without warning. Add missing availability annotations in URI tests Merge pull request from GHSA-r6r4-5pr8-gjcp Fix setting public folder for `FileMiddleware` when using bundles (vapor#3113) Consistently use the value from `X-Request-Id` as the request's ID when present (vapor#3117) Fix encoding and decoding of HTTPHeaders (vapor#3116) Add fully async entrypoints (vapor#3114) Bring back AsyncCommands (vapor#3109) General warnings and tests cleanup (vapor#3107) Add public initializer for `XCTHTTPRequest` (vapor#3106) [skip ci] Update dependabot.yml [skip ci] Fixup sponsors workflow Make Async Request Body actually work (vapor#3096) Create a thread pool of System.coreCount rather than 64 when initializing an Application (vapor#3092) Modernize sponsors automation workflow (vapor#3098) Bump the dependencies group with 2 updates (vapor#3099) Update README with new Sponsor (vapor#3101) ... # Conflicts: # Package.swift
These changes fix almost all of the extant warnings in Vapor, and clean up some issues in the tests, which can now run fully parallelized. There are no functional changes.