Bring back AsyncCommands #3109
Bring back AsyncCommands #3109
Conversation
|
I just saw my formatter went for a little rampage in |
|
Depends on: vapor/console-kit#195 |
| @@ -77,6 +83,7 @@ extension Application { | |||
| var commands = Commands() | |||
| commands.use(BootCommand(), as: "boot") | |||
| self.commands = .init(commands) | |||
| self.asyncCommands = .init(AsyncCommands()) | |||
There was a problem hiding this comment.
Tempted to say we should switch all the internals over but I think that can wait
There was a problem hiding this comment.
Yeah I was also thinking about that, but I'd say that belongs to a separate PR. 👍🏼
Co-authored-by: Tim Condon <0xTim@users.noreply.github.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3109 +/- ##
==========================================
+ Coverage 76.37% 76.41% +0.04%
==========================================
Files 211 211
Lines 8017 8031 +14
==========================================
+ Hits 6123 6137 +14
Misses 1894 1894
|
|
|
||
| app.asyncCommands.use(FooCommand(), as: "foo") | ||
|
|
||
| app.environment.arguments = ["vapor", "foo", "bar"] |
There was a problem hiding this comment.
Shouldn't this be
| app.environment.arguments = ["vapor", "foo", "bar"] | |
| app.environment.arguments = ["vapor", "foo", "--name", "bar"] |
There was a problem hiding this comment.
No it's an @Argument not @Option
|
|
||
| app.environment.arguments = ["vapor", "foo", "bar"] | ||
|
|
||
| XCTAssertNoThrow(try app.start()) |
There was a problem hiding this comment.
Is there any way we can verify it runs, like incrementing a global counter? A manual run will be good enough if you haven't done that. (Do we have any tests for normal commands)
There was a problem hiding this comment.
Good idea, I just pushed a commit. Unfortunately we don't have any tests for commands (or I couldn't find one)
|
Much appreciated! I can finally remove my workaround to use async in commands 🎉🎉🎉 References to other PRs #2870 #2853 vapor/console-kit#175 vapor/console-kit#181 |
* main: (44 commits) Update routing-kit version (vapor#3131) Use `singleton` `EventLoopGroup` (vapor#3128) Additional tests fixes Fix for Apple changing things without warning. Add missing availability annotations in URI tests Merge pull request from GHSA-r6r4-5pr8-gjcp Fix setting public folder for `FileMiddleware` when using bundles (vapor#3113) Consistently use the value from `X-Request-Id` as the request's ID when present (vapor#3117) Fix encoding and decoding of HTTPHeaders (vapor#3116) Add fully async entrypoints (vapor#3114) Bring back AsyncCommands (vapor#3109) General warnings and tests cleanup (vapor#3107) Add public initializer for `XCTHTTPRequest` (vapor#3106) [skip ci] Update dependabot.yml [skip ci] Fixup sponsors workflow Make Async Request Body actually work (vapor#3096) Create a thread pool of System.coreCount rather than 64 when initializing an Application (vapor#3092) Modernize sponsors automation workflow (vapor#3098) Bump the dependencies group with 2 updates (vapor#3099) Update README with new Sponsor (vapor#3101) ... # Conflicts: # Package.swift
These changes are now available in 4.88.0
Brings async commands back by adding a new property
asyncCommandstoApplication.