Add fully async entrypoints #3114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…()` and `run()` which handle use of async commands cleanly.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3114 +/- ##
==========================================
- Coverage 76.41% 76.34% -0.08%
==========================================
Files 211 211
Lines 8031 8035 +4
==========================================
- Hits 6137 6134 -3
- Misses 1894 1901 +7
|
0xTim
approved these changes
Dec 6, 2023
Joannis
reviewed
Dec 6, 2023
0xTim
approved these changes
Dec 6, 2023
patrick-zippenfenig
added a commit
to open-meteo/open-meteo
that referenced
this pull request
Dec 8, 2023
keniwhat
pushed a commit
to keniwhat/vapor
that referenced
this pull request
Jan 19, 2024
* main: (44 commits) Update routing-kit version (vapor#3131) Use `singleton` `EventLoopGroup` (vapor#3128) Additional tests fixes Fix for Apple changing things without warning. Add missing availability annotations in URI tests Merge pull request from GHSA-r6r4-5pr8-gjcp Fix setting public folder for `FileMiddleware` when using bundles (vapor#3113) Consistently use the value from `X-Request-Id` as the request's ID when present (vapor#3117) Fix encoding and decoding of HTTPHeaders (vapor#3116) Add fully async entrypoints (vapor#3114) Bring back AsyncCommands (vapor#3109) General warnings and tests cleanup (vapor#3107) Add public initializer for `XCTHTTPRequest` (vapor#3106) [skip ci] Update dependabot.yml [skip ci] Fixup sponsors workflow Make Async Request Body actually work (vapor#3096) Create a thread pool of System.coreCount rather than 64 when initializing an Application (vapor#3092) Modernize sponsors automation workflow (vapor#3098) Bump the dependencies group with 2 updates (vapor#3099) Update README with new Sponsor (vapor#3101) ... # Conflicts: # Package.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are now available in 4.89.0
Pretty much what it says on the tin. Use the new
execute()API instead ofrun(), and/orstartup()instead ofstart().