Skip to content
This repository has been archived by the owner on Jun 17, 2024. It is now read-only.

Khana.cs List Implementation #15

Closed
VargaDot opened this issue Nov 22, 2023 · 2 comments · Fixed by #9
Closed

Khana.cs List Implementation #15

VargaDot opened this issue Nov 22, 2023 · 2 comments · Fixed by #9
Assignees
@VargaDot
Labels
rewrite Rewrite or refactor of a piece of code
Milestone
Monopoly 1.0

Comments

@VargaDot
Copy link
Owner

The current architecture for Khana.cs uses Dictionary in a way that resembles Array for storing owned properties

public Dictionary<byte, Property> Portfolio {get; set;}

It is simply a weird way to register and is used to check whether a property is owned by someone by registering its Key as its PropertyID for... faster search?

One way to solve this would be to use Lists. i will research and see if its suitable
@VargaDot VargaDot added the rewrite Rewrite or refactor of a piece of code label Nov 22, 2023
@VargaDot VargaDot self-assigned this Nov 22, 2023
@VargaDot VargaDot linked a pull request Nov 22, 2023 that will close this issue
Major game refactor #9
Merged
@VargaDot
Copy link
Owner Author

oh yeah, this shit doesn't confuse me now

@VargaDot
Copy link
Owner Author

Research LINQ, may provide more readable code.

VargaDot added a commit that referenced this issue Nov 23, 2023
@VargaDot
Update Khana.cs
b077ead 
Solved #15
@VargaDot VargaDot added this to the Monopoly 1.0 milestone Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@VargaDot VargaDot

Labels
rewrite Rewrite or refactor of a piece of code
Projects
None yet
Milestone
Monopoly 1.0
Development

Successfully merging a pull request may close this issue.

Major game refactor VargaDot/Syndicate
1 participant
@VargaDot