Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Favourites menu #124

Closed
wiz0u opened this issue Oct 31, 2019 · 15 comments
Closed

Feature Request: Favourites menu #124

wiz0u opened this issue Oct 31, 2019 · 15 comments

Comments

@wiz0u
Copy link

wiz0u commented Oct 31, 2019

In addition to the Recent Files, add a Favourites menu that maintain a user list of files for quick opening.

I imagine two commands on top "Add current file", and "Remove from favourite..." (with a dialog box for selection), then a separator and the list of files.

If you don't want to display the full path of files here, you can shorten the display name to <last_directory_name>\<filename> that should be sufficient for most usage.
Also, sort the files by their display name.

Thanks :)

@wiz0u
Copy link
Author

wiz0u commented Oct 31, 2019

Related: maybe add an option somewhere to define the number of entries for "Recent files" (currently fixed at 5 ?)

@variar variar self-assigned this Nov 1, 2019
@variar variar added this to the 2019.12 milestone Nov 1, 2019
@variar
Copy link
Owner

variar commented Nov 1, 2019

Thanks for suggestions. With your help klogg is improving :) I'll look into this.

@variar variar modified the milestones: 2019.12, 2020.next Nov 15, 2019
@wiz0u
Copy link
Author

wiz0u commented Dec 19, 2019

Please consider increasing the priority for this Feature Request.
In my opinion this is the main lacking feature for klogg right now.
(it is so annoying having to navigate to each of the file I want to open everyday, even though they have a fixed network path and I don't want them always opened in klogg)

@variar variar modified the milestones: 2020.next, 2019.12 Dec 19, 2019
@wiz0u
Copy link
Author

wiz0u commented Dec 19, 2019

If you need to shorten a path for display, actually using an ellipsis in the middle is probably a better approach (\\network\path\...\to\file) than what I suggested in my initial post

variar added a commit that referenced this issue Dec 19, 2019
@variar
Copy link
Owner

variar commented Dec 19, 2019

Somewhat done in 19.12.0.532. Dialog to remove from favorites is very basic but will be improved in future versions.

@variar variar added the status: ready for testing resolved but needs testing label Dec 20, 2019
@variar
Copy link
Owner

variar commented Dec 20, 2019

Need to use native path separators

@wiz0u
Copy link
Author

wiz0u commented Dec 20, 2019

Somewhat done in 19.12.0.532. Dialog to remove from favorites is very basic but will be improved in future versions.

Neat !! Many thanks !!

Idea: The 'Remove' combobox could pre-select the current file if current tab is one of the favourites

Also see my suggestion above about ellipsis (so that it shows a bit of the beginning of the path also, in case the path/name is the same but on different network machines)

@wiz0u
Copy link
Author

wiz0u commented Dec 20, 2019

Oh, I just noticed the 'star' button to add/remove current file to favorites... Nice too :)

variar added a commit that referenced this issue Dec 21, 2019
@variar
Copy link
Owner

variar commented Dec 21, 2019

Added pre-selection and ellipsis. Thanks for ideas to improve klogg user expirience!

@wiz0u
Copy link
Author

wiz0u commented Dec 24, 2019

Ellipsis truncation seems not working correctly (not truncating or repeating parts) :

image

Also the tooltip and Remove dialog still uses forward slash instead of native path separator

@wiz0u
Copy link
Author

wiz0u commented Dec 24, 2019

I would recommend the following algorithm for ellipsis truncation:
If path is longer than 64 characters, and composed of more than 5 "words" (including drive letter, network machine name, folder name, or file name), keep the first two and the last two, and put "..." in the middle (keeping the backward/forward slashes, colon or double-slashes separators as-is)

Note that it would mean the above two examples in my screenshot should not be truncated (and I'm fine with it)

Happy end of year festivities!

@variar
Copy link
Owner

variar commented Dec 25, 2019

Thanks for algorithm idea, will look into it. Implemented simplier version for now in 19.12.0.540

@wiz0u
Copy link
Author

wiz0u commented Dec 27, 2019

Other problems are fixed now.

For truncation, as an example, I would expect
R:\MMTools\...\20181010\1605.xml or R:\MMTools\PCAL\...\20181010\1605.xml
for the following:
image
(showing the name of the parent directory is important)

@variar
Copy link
Owner

variar commented Dec 27, 2019

Moved truncation to separate issue for future consideration

@variar variar closed this as completed Dec 27, 2019
@variar
Copy link
Owner

variar commented Jan 4, 2020

Part of nickbnf#147

@variar variar removed the status: ready for testing resolved but needs testing label Jan 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants