Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Highlighters]: change buttons to "flagged" buttons in sets lists #551

Open
PetbkA opened this issue Apr 23, 2023 · 3 comments
Open

[Highlighters]: change buttons to "flagged" buttons in sets lists #551

PetbkA opened this issue Apr 23, 2023 · 3 comments
Milestone

Comments

@PetbkA
Copy link

PetbkA commented Apr 23, 2023

After #534 I've started to enable only the approriate highlighter sets, depending on the log I'm viewing.

The problem is that sometimes I need to enable e.g. 3 sets and disable couple of others at the same time. Now I have to open menu → Click on one of sets (Menu will be closed) → Open menu again → Click on the other set (Menu will be closed) and so on.

It's better to do this on one menu opening, so I proprose to change highlighter sets buttons to "flagged" buttons, so clicking on sets wouldn't close the menu but only changed set's state.

Also flags for sets would be nice in Configure highlighters... menu - for example to see the effect of set you've just created. Of course, setting flag on Space button and selecting several sets (including selecting all on Ctrl + A) would be nice.

If #502 is planned to be implemented someday, it should be kept in mind while implementing this one

@PetbkA PetbkA changed the title [Highlighters]: change buttons to "flagged" buttons in Highlighters list [Highlighters]: change buttons to "flagged" buttons in sets lists Apr 23, 2023
@variar variar added this to the 2023.next milestone Jun 14, 2023
nowhszh added a commit to nowhszh/klogg that referenced this issue Aug 3, 2023
nowhszh added a commit to nowhszh/klogg that referenced this issue Aug 3, 2023
@nowhszh
Copy link

nowhszh commented Aug 5, 2023

I also use this feature a lot, and it does have a bad interaction experience when selecting multiple highlighters, so I implemented this issue. before merging you can download it via the CI product
https://github.com/variar/klogg/actions/runs/5753292015?pr=660#artifacts

nowhszh added a commit to nowhszh/klogg that referenced this issue Aug 7, 2023
variar pushed a commit that referenced this issue Aug 13, 2023
* feat: trigger the highlisters menu without closing(#551)

* fix: display error of None Action in the highlighters menu

* fix: Right-click menu highlighters are invalid in other logview
@PetbkA
Copy link
Author

PetbkA commented Aug 16, 2023

23.08.0.1580 x64 Qt6 - implemented and works OK in HL sets list, which, I guess, is fine for 99% users. Still no flags for HL sets in menu (although I doubt that it's easy to implement and thus needed at all).

Also it would be nice if None would also work like flag, i.e. "unchecking" it back would enable all HL sets that were enabled before None was "checked"

@nowhszh
Copy link

nowhszh commented Aug 16, 2023

The function of “None” is to deselect the selected HL, when no HL is selected it is unavailable, the available and unavailable states are displayed differently to indicate availability.
I think what you want is a separate function to select all HLs and deselect them all, more like an upgrade to “None”.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants