Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trigger the highlisters menu without closing #660

Merged
merged 3 commits into from Aug 13, 2023
Merged

Conversation

nowhszh
Copy link

@nowhszh nowhszh commented Aug 3, 2023

This pull request is to add a feature(#551). But some bugs were found during development, so I fixed it by the way.
Modify as follows:

  • When clicking the action in the highlighters menu, the menu list is not hidden
  • Fix the display error of None Action in the highlighters menu
  • Fix that the highlighters in the right-click menu only take effect in the current logview

before

img_v2_6cbd759b-5ab2-47c7-b827-cbc21421501l

fixed

img_v2_33888b57-66c3-4fce-81e0-eb2df8672d1l

@nowhszh
Copy link
Author

nowhszh commented Aug 3, 2023

I also found another bug while modifying.
The highlighters in the right mouse button only take effect immediately in the current logview, but because the problem is not serious and there is no good idea to fix it, there is no change for the time being.

Fixed.

@variar
Copy link
Owner

variar commented Aug 13, 2023

Thanks! That is easier to use that way

@variar variar merged commit e7b361f into variar:master Aug 13, 2023
12 of 13 checks passed
@nowhszh nowhszh deleted the fix-none branch August 16, 2023 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants