Skip to content
This repository has been archived by the owner on May 8, 2023. It is now read-only.

[Enhancement] Merge viewport and targeting so viewport info can be used in segments #22

Closed
foxted opened this issue Dec 30, 2019 · 0 comments · Fixed by #23
Closed

[Enhancement] Merge viewport and targeting so viewport info can be used in segments #22

foxted opened this issue Dec 30, 2019 · 0 comments · Fixed by #23
Labels
core Related to the core functionality of the engine enhancement Enhancement of an existing feature

Comments

@foxted
Copy link
Member

foxted commented Dec 30, 2019

Feature

Viewport and targeting are currently separate in the environment object. Would be nice to merge them to allow users to create segments on viewport info.

Screen Shot 2019-12-29 at 20 46 12

Ideal solution

Merge viewport and targeting objects into a visitor object to allow segmentation on any property including viewport info.
@foxted foxted added enhancement Enhancement of an existing feature core Related to the core functionality of the engine labels Dec 30, 2019
@foxted foxted mentioned this issue Jan 2, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
core Related to the core functionality of the engine enhancement Enhancement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Targeting VariateHQ/variate-engine
1 participant
@foxted