Skip to content

Commit

Permalink
mark a tbd: For background fetches from vcl_hit, should we go to vcl_…
Browse files Browse the repository at this point in the history
…miss ?

There might be code in vcl_miss changing the request which we don't
run for bgfetches, which could lead to unexpected behaviour.

On the other hand, what purpose does vcl_miss serve? Is there anything
we can do in vcl_miss which we can't do in vcl_backend_fetch?
  • Loading branch information
nigoroll committed Feb 24, 2018
1 parent 9b785fd commit 79e91c0
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions bin/varnishd/cache/cache_req_fsm.c
Original file line number Diff line number Diff line change
Expand Up @@ -529,6 +529,7 @@ cnt_lookup(struct worker *wrk, struct req *req)
if (busy != NULL) {
AZ(oc->flags & OC_F_PASS);
CHECK_OBJ_NOTNULL(busy->boc, BOC_MAGIC);
// XXX: shouldn't we go to miss?
VBF_Fetch(wrk, req, busy, oc, VBF_BACKGROUND);
} else {
(void)VRB_Ignore(req);// XXX: handle err
Expand Down

0 comments on commit 79e91c0

Please sign in to comment.