nuke_limit is not honored

[bsdphk]

Old ticket imported from Trac:

nuke_limit doesn't seem to have any effect anymore. It looks like stv_alloc_obj is called multiple times per object, and only does one allocation, so it never hits nuke_limit.

[gquintard]

nuke_limit is not honored anymore. relevant vtc:

varnishtest "Test nuke_limit"

server s1 {
    # First consume (almost) all of the storage
    rxreq
    expect req.url == /url1
    txresp -bodylen 200000

    rxreq
    expect req.url == /url2
    txresp -bodylen 200000

    rxreq
    expect req.url == /url3
    txresp -bodylen 200000

    rxreq
    expect req.url == /url4
    txresp -bodylen 200000

    rxreq
    expect req.url == /url5
    txresp -bodylen 1000000
} -start

varnish v1  -arg "-smalloc,1M" -arg "-p nuke_limit=3" -vcl+backend {
    sub vcl_backend_response {
        set beresp.do_stream = false;
    }
} -start


client c1 {
    txreq -url /url1
    rxresp
    expect resp.status == 200

    txreq -url /url2
    rxresp
    expect resp.status == 200

    txreq -url /url3
    rxresp
    expect resp.status == 200

    txreq -url /url4
    rxresp
    expect resp.status == 200

    txreq -url /url5
    rxresp
    expect resp.status == 503
} -run

[hermunn]

Backport review: This is backported by @mbgrydeland (365e605) and is part of 4.1.7-beta1. For some users this fix will change the behavior of varnish in a significant way, but for most people it will not be noticed.

[ThomasHector]

Hi,

After the security bug we updated our varnish cluster from 4.1.1 -> 4.1.8

After a few days we realized a new issue, which i pretty much think is due to nuked objects.
After a restart of varnish and until MAIN.n_lru_nuked is larger then 0 everything works fine.
But when MAIN.n_lru_nuked exceeds lets say 100 only chunks of content gets cached. For eksample video files (flv in this case) which has a size between 100-200mb each is suddenly served as 1-3mb instead. This results in the videos stalls after som secs of cause.

I then saw the following:

The default nuke_limit is 10, and this number is high enough to not
affect most users. However, if you want to make sure that the
behavior is not changed when upgrading, you should set the value much
higher.

Therefore I have these questions

1. What happens when the limit 10 get exceeded?
2. We have a rather large varnish cluster, but still nukes severel 1000 a day. Never been a problem, but since 4.1.7 it is. Should we just bumped the value to 9999999 or is there a problem with doing that?
3. Are we able to disable the nuke_limit eg. 0 ?

[hermunn]

1. If the nuke limit is reached, the Varnish will serve a 503.
2. Yes, bumping to a really high number is the right thing. 9999999 is probably a good value.
3. No, zero is not a special value. With 0 there will be no RLU nuking at all.

This is one of very few patches after 4.1 that can affect a running varnish in a negative way, and it is present in all versions from 4.1.7-beta1 and onwards.

[dridi]

This is a topic for the misc mailing list, but the short story is that the nuke_limit is per-transaction, and the n_lru_nuked is global. @INCRE f you have more questions, please ask them on the mailing list.