New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"varnishstat -f MAIN.sess_conn -1" produces empty output #2118

Closed
gquintard opened this Issue Oct 26, 2016 · 6 comments

Comments

Projects
None yet
7 participants
@gquintard
Contributor

gquintard commented Oct 26, 2016

varnishstat -f PATTERN -1 produces empty output if PATTERN is a full counter name (such as "MAIN.sess_conn")

Expected Behavior

varnishstat should return the information about the counter named PATTERN

Your Environment

Happens on 5.0.

@hermunn

This comment has been minimized.

Show comment
Hide comment
@hermunn

hermunn Nov 18, 2016

Contributor

Backport review: @gquintard's comment indicates that this is 5.0 only, so there is nothing to backport.

Contributor

hermunn commented Nov 18, 2016

Backport review: @gquintard's comment indicates that this is 5.0 only, so there is nothing to backport.

@zstyblik

This comment has been minimized.

Show comment
Hide comment
@zstyblik

zstyblik Jan 16, 2017

Hello,

I've applied patch from the commit, but situation hasn't changed. varnishstat still cannot reference eg. MAIN.cache_hit. :\

Thank you for any help.

zstyblik commented Jan 16, 2017

Hello,

I've applied patch from the commit, but situation hasn't changed. varnishstat still cannot reference eg. MAIN.cache_hit. :\

Thank you for any help.

@fgsch

This comment has been minimized.

Show comment
Hide comment
@fgsch

fgsch Jan 16, 2017

Member

You are doing something wrong if it's not working but I'm afraid this is not the right place for support.
Check https://varnish-cache.org/support/ for the correct channels.

Member

fgsch commented Jan 16, 2017

You are doing something wrong if it's not working but I'm afraid this is not the right place for support.
Check https://varnish-cache.org/support/ for the correct channels.

@zstyblik

This comment has been minimized.

Show comment
Hide comment
@zstyblik

zstyblik Jan 16, 2017

@fgsch, it was my bad indeed. patch is in libvarnishapi, therefore deploying varnish debpkg alone doesn't make sense. Thank you for the kick and sorry for the noise. Patch works.

zstyblik commented Jan 16, 2017

@fgsch, it was my bad indeed. patch is in libvarnishapi, therefore deploying varnish debpkg alone doesn't make sense. Thank you for the kick and sorry for the noise. Patch works.

mbgrydeland added a commit that referenced this issue Jun 15, 2017

Ident and type are optional
Update the code to accommodate this.  Originally reported by Reinis
Rozitis (r at roze.lv) on varnish-misc.

Fixes #2118.

Backport to 4.1

ibreger added a commit to thomsonreuters/varnish-cache that referenced this issue Jun 27, 2017

Ident and type are optional
Update the code to accommodate this.  Originally reported by Reinis
Rozitis (r at roze.lv) on varnish-misc.

Fixes #2118.

Backport to 4.1

wmfgerrit pushed a commit to wikimedia/operations-debs-varnish4 that referenced this issue Jun 29, 2017

4.1.7-1wm1: new upstream, new counters
Package varnish 4.1.7, add counters for transient storage.

Introduce a new counter for shortlived objects creation,
cache_shortlived, and another one for uncacheable responses,
cache_uncacheable. They should provide insights when it comes to
monitoring transient storage usage.

Changes in 4.1.7:

 - Correctly honor nuke_limit parameter
   varnishcache/varnish-cache#1764
 - Prevent storage backends name collisions
   varnishcache/varnish-cache#2321
 - varnishstat -1 -f field inclusion glob doesn't allow VBE backend fields
   varnishcache/varnish-cache#2022
 - Health probes fail when HTTP response does not contain reason phrase
   varnishcache/varnish-cache#2069
 - "varnishstat -f MAIN.sess_conn -1" produces empty output
   varnishcache/varnish-cache#2118
 - Remember to reset workspace
   varnishcache/varnish-cache#2219
 - Rework and fix varnishstat counter filtering
   varnishcache/varnish-cache#2320
 - Docfix: Only root can jail
   varnishcache/varnish-cache#2329
 - Don't panic on a null ban
 - Add extra locking to protect the pools list and refcounts
 - Add -vsl_catchup to varnishtest
 - Add record-prefix support to varnishncsa

Bug: T164768
Ref: https://github.com/varnishcache/varnish-cache/blob/4.1/doc/changes.rst#varnish-cache-417-2017-06-28
Change-Id: I8a8f3a8103feb83b1a55a6788ea6c5d12963b4f5
@venkat-rafay

This comment has been minimized.

Show comment
Hide comment
@venkat-rafay

venkat-rafay Aug 14, 2018

This issue still persists with varnish-5.0.0 revision 99d036f. Could someone clarify whether this patch has been published in a later revision?

venkat-rafay commented Aug 14, 2018

This issue still persists with varnish-5.0.0 revision 99d036f. Could someone clarify whether this patch has been published in a later revision?

@Dridi

This comment has been minimized.

Show comment
Hide comment
@Dridi

Dridi Aug 14, 2018

Member

If you look at the patch b21b0d7 with a git client or directly on github you can see that this patch was first released with Varnish 5.1.0.

Member

Dridi commented Aug 14, 2018

If you look at the patch b21b0d7 with a git client or directly on github you can see that this patch was first released with Varnish 5.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment