Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite of the viewer logic #128

Closed
martin-schlipf opened this issue Jan 16, 2024 · 0 comments · Fixed by #142
Closed

Rewrite of the viewer logic #128

martin-schlipf opened this issue Jan 16, 2024 · 0 comments · Fixed by #142
Milestone

Comments

@martin-schlipf
Copy link
Collaborator

The viewer should follow more closely the logic that is used for Graph. Specifically, the relevant py4vasp routines have a routine to_viewer and a wrapper plot that calls it. The viewer than contains all data required to produce the 3d view with attributes to set quantities.
Note that we should discuss specifics with Manuel. He might want to write a javascript library that generates the figures with Babylon or Three.JS directly. A preliminary step may be to rewrite the NGL interface but we should not invest to much time if the JS library gets developed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant