Reattach SR icon is non-obvious

[gitterdude]

Context

• XO origin: the sources / XO Appliance
• Versions:
  • xo : 6518-ge88848c44
  • xo-web: 5.42.1
  • xo-server: 5.42.1

Suggested behavior

Instead of having a white-chain icon next to "Storage usage" on the New/SR page there should be a "Reattach" button to the right of "Create".

Like this:

[Fohdeesha]

bumping this

[olivierlambert]

@pdonias feel free to assign the right person, we need to plan it sooner than later.

[pdonias]

IIRC, there can be more than one SR to in the list of reattachable SRs and each of them has its "reattach" button next to it. What should happen in that case?

@Fohdeesha If I understood correctly, the problem is when the user clicks "Create" when there's a SR that can be reattached? Maybe we can show a confirmation modal in that case, then?

[julien-f]

If the risk is to wipe the SR, maybe a confirmation modal would be enough?

[Fohdeesha]

I thought we already had a confirmation dialog reporting that the SR will be wiped of existing VM disks (if it detects the SR had a previous datastore). If not we should definitely have this yes. Maybe in this same dialog box we can add the "re-attach" option alongside a "initialize as new" button or similar? I think that would be the best of both worlds (then we don't have to show link/reattach buttons for every detected SR in the SR list)

[julien-f]

@Fohdeesha We really try to not work on XO5 anymore (otherwise we'll never be able to release XO6) so we should make sure this is necessary and find the simplest solution possible.

[Fohdeesha]

Well considering this has caused multiple customers to completely wipe entire SRs worth of VM disks, I would consider it absolutely necessary to at least have a confirmation dialog explaining the SR will be totally wiped, and to re-link if they desire to re-use the data.

[tig987]

The same should be available for local SR.