Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

match $x sub thing; get; throws error #38

Closed
sorsaffari opened this issue Dec 13, 2018 · 3 comments · Fixed by #185
Closed

match $x sub thing; get; throws error #38

sorsaffari opened this issue Dec 13, 2018 · 3 comments · Fixed by #185
Assignees
@sorsaffari
Labels
status: solved type: bug
Milestone
1.2.3

Comments

@sorsaffari
Copy link

Grakn version: 1.4.0

Reproducing steps:

  1. select any keyspace
  2. in Graql Editor, enter match $x sub thing; get;
  3. execute

Expected outcome:

visualise all labels with no errors.

Actual outcome

visualises all (?) labels including one blank node and the error message: n.attributes is not a function
@marco-scoppetta marco-scoppetta transferred this issue from typedb/typedb Feb 26, 2019
@Irtazaraza Irtazaraza added this to the 1.2.3 milestone Jul 9, 2019
@marco-scoppetta
Copy link

@sorsaffari @Irtazaraza please let's prioritise this bug

@sorsaffari
Copy link
Author

@marco-scoppetta could you please elaborate why you'd give this high priority?

@marco-scoppetta
Copy link

this is a basic query that people tend to try as a first thing when opening Workbase. Also it should be a fairly easy fix

@sorsaffari sorsaffari modified the milestones: 1.2.4, 1.2.3 Aug 5, 2019
@sorsaffari sorsaffari changed the title match $x sub thing; get; throws error match $x sub thing; get; throws error (1) Aug 5, 2019
@sorsaffari sorsaffari self-assigned this Aug 7, 2019
@Irtazaraza Irtazaraza removed their assignment Aug 8, 2019
@sorsaffari sorsaffari changed the title match $x sub thing; get; throws error (1) match $x sub thing; get; throws error Aug 13, 2019
@sorsaffari sorsaffari mentioned this issue Aug 14, 2019
Merged
sorsaffari pushed a commit that referenced this issue Aug 29, 2019
Unifies the logic for producing Canvas nodes and edges (#185)
af6ae9e 
##  What is the goal of this PR?
For the purpose of reducing complexity, the logic in producing nodes and edges based on a given concept or answer is now unified within one module.

## What are the changes implemented in this PR?
resolves #38 
- updates `.gitignore` to not ignore `.vscode` for the purpose of sharing `launch.json`
- modifies `SchemaDesign/store/actions.js` and `Visualiser/store/actions.js` to use the recently added `CanvasDataBuilder`
- implements `CanvasDataBuilder.js` as the only module that builds nodes and edges based on Graql query answers and concepts
- comments out the `UPDATE_METATYPE_INSTANCES` test as it needs to be moved to integration tests (#182)
- modifies previous tests based on the changes introduced in this PR
- tests CanvasDataBuilder with the exception of `buildRPInstances` (#184)



Note: Some of the functions that were meant to be replaced by the components of CanvasDataBuilder are still kept and used by parts of the code that are yet to be refactored. (#183)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorsaffari sorsaffari

Labels
status: solved type: bug
Projects
None yet
Milestone
1.2.3
Development

Successfully merging a pull request may close this issue.

Unifies the logic for producing Canvas nodes and edges sorsaffari/workbase
4 participants
@sorsaffari @Irtazaraza @marco-scoppetta @grabl