-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support different timetables for different campuses #169
Comments
Just thought I should add this here, this is what my Winter Semester 2020-21 timetable looks like (Chennai campus, BCE). It was different for Fall Semester 2020-21, the timings were different and he had a few more slots. They updated VTOP so that you can only view timetables for the semesters you have registered for, so I'm not sure if it's the same for other branches or what the next semester's timetable will look like. Can someone add what it looks like for the Vellore campus? If VIT is going to be making changes like this often, I feel it'll be better to resolve this in a way where changing slots and timings in future doesn't take a lot of effort. |
The current timetable we are using in this site is what Vellore is using currently (best to my knowledge). @sanket9918 can confirm and help you with any more information you'd want.
Yes, that the idea here. Support multiple timetable and make it easier to update timetables. One of the approaches I can think of for achieving this is to have a define a timetable schema (probably json). And we should write a generic function which takes this schema and renders the timetable accordingly. I feel this is easier to do with our current codebase. Open to other solutions. |
Yeah, I was thinking the same. I think someone is already working on a patch? If not I'll see what I can do next week as this would cause conflicts with the redesign (#172). If there are different layouts for other branches we'll be able to support them too by giving an option to select a layout. The schema's can be defined in files like |
You can pick it up next week. Sync with @hariketsheth once if he has made any progress on it |
This is what the Winter Semester 2020-21 timetable looks like (Vellore campus, BCE). Can @sanket9918 confirm? |
This comment has been minimized.
This comment has been minimized.
I've made some progress on this one, timetable schemas can easily be changed in the JSON file in future if any changes are required. The only thing left is to figure out how to check for slot clashes, will probably have to make use of JavaScript's FFCS.On.The.Go.-.VIT.University.-.31.December.2021.mp4 |
Is your feature request related to a problem? Please describe.
Currently we only have one timetable for both Vellore and Chennai campuses. This works well if timetable followed by both campuses are same. But in case the timetable is different for both the campuses we don't have a way to support both of them.
Describe the solution you'd like
Add support for different timetables for different campuses. This will require good efforts in terms of refactoring existing code.
Must ideal refactoring is moving to react or preact but it's lot of efforts. It'll also require re-writing all of jquery code.
Easiest approach I can think of is to write a helper function which takes a schema of timetable and renders it accordingly. We can call this function with correct schema when changing the campus and re-render the timetable.
Describe alternatives you've considered
In past, similar problem was solved by deploying different code on a different route. I don't think it's a good approach.
Additional context
#168
The text was updated successfully, but these errors were encountered: