Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth1Authenticator improperly handles url and parameters #36

Closed
3 tasks done
timhall opened this issue May 9, 2014 · 2 comments · Fixed by #37
Closed
3 tasks done

OAuth1Authenticator improperly handles url and parameters #36

timhall opened this issue May 9, 2014 · 2 comments · Fixed by #37

Comments

@timhall
Copy link
Member

timhall commented May 9, 2014

From http://oauth.net/core/1.0/#anchor14 the signature base string has very specific formatting for the request url and request parameters. This improper formatting caused issues with accessing the LinkedIn API.

Test against https://developer.linkedin.com/oauth-test-console

Todo:

  • Use OAuth1 formatting for request url (exclude query and hash, include port if not 80 or 443, lowercase protocol and host)
  • Use proper format and ordering for request parameters
  • Include explicit querystring parameters and implicit (included as part or Resource) with request parameters (including cachebreaker)
@timhall timhall added the bug label May 9, 2014
@timhall
Copy link
Member Author

timhall commented May 9, 2014

(in progress)

@timhall timhall removed the bug label May 9, 2014
@timhall
Copy link
Member Author

timhall commented May 12, 2014

(Ordering of parameters has been deferred until a future update)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant