Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Curl authentication on MAC #89

Closed
gavin-hay opened this issue Feb 3, 2015 · 1 comment · Fixed by #92
Closed

Curl authentication on MAC #89

gavin-hay opened this issue Feb 3, 2015 · 1 comment · Fixed by #92
Labels
bug

Comments

@gavin-hay
Copy link

I found a defect in the HTTPAuthenticator

On OS X the password should be escaped to deal with special characters to bash. For example, I had a "!" in my password with failed the call. In the WebAuthenticator_PrepareCurl method, I replaced:

Curl = Curl & " --basic --user " & Me.Username & ":" & Me.Password

with

Curl = Curl & " --basic --user " & Me.Username & ":" & Replace(Me.Password, "!", "\!")
@timhall
Copy link
Member

timhall commented Feb 3, 2015

Good call @gavin-hay, I'll fix that today

@timhall timhall added the bug label Feb 4, 2015
@timhall timhall mentioned this issue Feb 4, 2015
Closed
timhall added a commit that referenced this issue Feb 4, 2015
@timhall
cURL escape authenticators (fixes #89)
75315bf
@timhall timhall mentioned this issue Feb 4, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfixes (cURL escaping, url-encode UrlSegments, add SetHeader) VBA-tools/VBA-Web
2 participants
@timhall @gavin-hay