Skip to content

Commit

Permalink
sagemathgh-36947: sage -package download: Fix argparse for `--no-ch…
Browse files Browse the repository at this point in the history
…eck-certificate`

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->
A mistake in sagemath#36774 broke the macOS CI in 10.3.beta3, see
https://github.com/sagemath/sage/actions/runs/7255417440/job/19765989346
#step:9:1425
```
  [patch-2.7.5] error installing, exit status 1. End of log file:
  [patch-2.7.5]   usage: sage --package [-h] [--log LOG] [--no-check-
certificate]
  [patch-2.7.5]
{config,list,name,tarball,apropos,update,update-
latest,download,upload,fix-checksum,create,clean}
  [patch-2.7.5]                         ...
  [patch-2.7.5]   sage --package: error: unrecognized arguments: --no-
check-certificate
  [patch-2.7.5]
************************************************************************
  [patch-2.7.5]   Error downloading tarball of patch
  [patch-2.7.5]
************************************************************************
```

We make the one-line fix for this here.

Tests (with other merged branches) at
https://github.com/mkoeppe/sage/actions/runs/7295997767/job/19883171237

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36947
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
  • Loading branch information
Release Manager committed Jan 12, 2024
2 parents 4854839 + de08b80 commit bcfbd5e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build/sage_bootstrap/cmdline.py
Original file line number Diff line number Diff line change
Expand Up @@ -292,7 +292,7 @@ def make_parser():
parser_download.add_argument(
'--on-error', choices=['stop', 'warn'], default='stop',
help='What to do if the tarball cannot be downloaded')
parser.add_argument(
parser_download.add_argument(
'--no-check-certificate', action='store_true',
help='Do not check SSL certificates for https connections')

Expand Down

0 comments on commit bcfbd5e

Please sign in to comment.