Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allows optional path #11

Closed
vch9 opened this issue Aug 23, 2021 · 3 comments
Closed

Allows optional path #11

vch9 opened this issue Aug 23, 2021 · 3 comments
Milestone
Version 0.3

Comments

@vch9
Copy link
Owner

vch9 commented Aug 23, 2021

A default path should be considered for snapshots.
@vch9 vch9 added this to the Version 0.3 milestone Aug 25, 2021
@vch9 vch9 mentioned this issue Oct 5, 2021
Closed
@vch9
Copy link
Owner Author

vch9 commented Oct 6, 2021

Done in f728de6.

@vch9 vch9 closed this as completed Oct 6, 2021
@vch9 vch9 mentioned this issue Oct 6, 2021
Merged
@vch9
Copy link
Owner Author

vch9 commented Oct 7, 2021

Reopening this as I'm not a big fan (of my own solution). I don't have much confidence is the optional path created when it is called with dune runtest. Also, the test should be able to create a default path (e.g. ./) when it's called via the executable.

@vch9 vch9 reopened this Oct 7, 2021
@vch9
Copy link
Owner Author

vch9 commented Oct 11, 2021

Now, when it fails to find the _build\default path, it is stored in the current path.

@vch9 vch9 closed this as completed Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.3
Development

No branches or pull requests
1 participant
@vch9