Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Player shouldn't be able to control defending units, when his external dwellings are attacked #1965

Closed
krs0 opened this issue Apr 12, 2023 · 3 comments · Fixed by #2405
Closed

Player shouldn't be able to control defending units, when his external dwellings are attacked #1965

krs0 opened this issue Apr 12, 2023 · 3 comments · Fixed by #2405
Assignees
@nullkiller
Labels
bug nullkillerai AI issues on adventure map vcai visibility Data visibile to players

Comments

@krs0
Copy link
Collaborator

krs0 commented Apr 12, 2023

Describe the bug
If a player owns an external dwelling and another player tries to take it, AI should fight not dwelling owner.

Needs to be fixed like in OH3, but this is a very nice VCMI feature, that should be made an option that can be activated via mod.

To Reproduce
Steps to reproduce the behavior:

  1. Start attached map in hotseat
  2. take dwelling
  3. end turn until new week
  4. take dwelling with Blue player
  5. in fight red controls the angel!!!

A Dwelling Guards Test.zip

Mantis: https://bugs.vcmi.eu/view.php?id=2564
@krs0 krs0 added the bug label Apr 12, 2023
@krs0 krs0 changed the title Player shouldn't be able to control defence of his external dwellings Player shouldn't be able to control defending units, when his external dwellings are attacked Apr 13, 2023
@DjWarmonger DjWarmonger added vcai nullkillerai AI issues on adventure map visibility Data visibile to players labels Jul 23, 2023
@nullkiller
Copy link
Member

It is not AI related if I understood it correctly. Human can control defending creatures of 5+ dwelling levels.
Checked the map. With controlai cheat you can control both attacker and defender. It may be very old bug actually.

@nullkiller
Copy link
Member

Looks like we need to treat defender of dwelling as a neutral player always

@nullkiller
Copy link
Member

Fixed it, will make a PR soon

@nullkiller nullkiller self-assigned this Jul 24, 2023
nullkiller added a commit that referenced this issue Jul 25, 2023
@nullkiller
#1965 - treat dwelling defenders as neutrals
ec8898a
@nullkiller nullkiller linked a pull request Jul 25, 2023 that will close this issue
#1965 - treat dwelling defenders as neutrals #2405
Merged
DjWarmonger added a commit that referenced this issue Jul 25, 2023
@DjWarmonger
Merge pull request #2405 from vcmi/fix-2389
ae1aa81 
#1965 - treat dwelling defenders as neutrals
@nullkiller nullkiller mentioned this issue Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nullkiller nullkiller

Labels
bug nullkillerai AI issues on adventure map vcai visibility Data visibile to players
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1965 - treat dwelling defenders as neutrals vcmi/vcmi
4 participants
@IvanSavenko @DjWarmonger @nullkiller @krs0