Issue/2137 #116
Merged
Issue/2137 #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe Catapult should skip it's action if there are no walls left, no matter if player has Ballistics or not. Also we can imagine hypothetical situation when there's Catapult with no related hero. |
|
Ok, I'll check and refactor a bit all actions for catapult |
No target -> Pass No player or no ballistics -> automatic action Else -> manual action
| { | ||
| BattleAction attack; | ||
| attack.destinationTile = *RandomGeneratorUtil::nextItem(attackableBattleHexes, gs->getRandomGenerator()); | ||
| attack.destinationTile = *RandomGeneratorUtil::nextItem(attackableBattleHexes, | ||
| gs->getRandomGenerator()); |
DjWarmonger
pushed a commit
that referenced
this pull request
Aug 29, 2015
Okay, thank you for your contribution :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug getting catapult action when hero has ballistics and no more target to shoot