Fix 2160 dismissing a VIP hero #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1454,3 +1455,27 @@ bool CGHeroInstance::hasVisions(const CGObjectInstance * target, const int subty | |||
|
|
|||
| return (distance < visionsRange) && (target->pos.z == pos.z); | |||
| } | |||
|
|
|||
| bool CGHeroInstance::isMissionCritical(const CMap* map) const | |||
There was a problem hiding this comment.
Map objects should not use map pointers from outside. For now they should use IObjectInterface::cb for game state access.
There was a problem hiding this comment.
As for triggeredEvents it may be IObjectInterface::cb->getMapHeader()->triggeredEvents
vmarkovtsev
force-pushed
the
issue/2160
branch
from
aedf05a
to
9f33135
Compare
|
@alexvins did what you said, API got better anyway +1 |
alexvins
added a commit
that referenced
this pull request
Jan 27, 2016
Fix 2160 dismissing a VIP hero.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix http://bugs.vcmi.eu/view.php?id=2160