Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/2304/2418 #197

Merged
merged 16 commits into from Mar 1, 2016
Merged

Issues/2304/2418 #197

merged 16 commits into from Mar 1, 2016

Conversation

@ArseniyShestakov
Copy link
Member

ArseniyShestakov commented Feb 27, 2016

Since it's easier to put feedback via pull requests here we go:
http://bugs.vcmi.eu/view.php?id=2304
http://bugs.vcmi.eu/view.php?id=2418

…s clone when killed.
@ArseniyShestakov

This comment has been minimized.

Copy link
Member Author

ArseniyShestakov commented Feb 27, 2016

So first problem is that we can't handle summoned creatures exactly as clones because it's breaking one-elemental limit check. Since stack disappear we can no longer check if there was creature summoned or no. Related issue:
http://bugs.vcmi.eu/view.php?id=2293

There also related not implemented feature. H3 had special limit of how many stacks could ever fight for one side on battlefield which is 20 stacks. So it's another reason to make some storage for all stacks.

@DjWarmonger

This comment has been minimized.

Copy link
Member

DjWarmonger commented Feb 27, 2016

20 stack limit actually made WoG crash in some scenarios and in general was troublesome. I don't think we need to impose it, it has no impact in OH3 - but could give additional possibilities in mods.

@alexvins

This comment has been minimized.

Copy link
Member

alexvins commented Feb 27, 2016

that we can't handle summoned creatures exactly as clones

We can, but just do not delete them. Will do this way.

@ArseniyShestakov

This comment has been minimized.

Copy link
Member Author

ArseniyShestakov commented Feb 27, 2016

@DjWarmonger I didn't mean that we must enforce it by default, but we still need to have options that make VCMI behaviour as close to H3 as possible. And some limit is totally reasonable from balance standpoint anyway.

alexvins added 2 commits Feb 27, 2016
* exclude ghost stacks from (hopefully all) get* results for now
@alexvins

This comment has been minimized.

Copy link
Member

alexvins commented Feb 28, 2016

@ArseniyShestakov it is even possible with current mechanics to have more than 20 stacks on one side without mods?

@ArseniyShestakov

This comment has been minimized.

Copy link
Member Author

ArseniyShestakov commented Feb 28, 2016

Idea is that 20 is total limit of stacks, not just alive one. 7 stacks is your army, up to 3 war machines.
So you can summon creatures up to 10 times, but after that point you won't be able to summon anything, even demons.

@alexvins

This comment has been minimized.

Copy link
Member

alexvins commented Feb 28, 2016

  1. 7 normal + 7 clones + 3 war machines + 3 arrow towers + 1 elemental + 1 daemon = 22 (!). (But may be towers does not count)
  2. 7 normal + 7 clones + 4 war machines + 1 elemental + 1 daemon = 20. (+optional commander = 21)
@dydzio0614

This comment has been minimized.

Copy link
Member

dydzio0614 commented Feb 28, 2016

Maybe mechanical limit makes sense in cases like the one here: https://www.youtube.com/watch?v=tuy_ncoBhGM

@alexvins alexvins changed the title Issues/2304/2418 [WiP] Issues/2304/2418 Feb 28, 2016
alexvins added 3 commits Feb 29, 2016
@alexvins

This comment has been minimized.

Copy link
Member

alexvins commented Mar 1, 2016

@dydzio0614 @ArseniyShestakov Anyway, 20 stack limit is off-topic here.

@ArseniyShestakov

This comment has been minimized.

Copy link
Member Author

ArseniyShestakov commented Mar 1, 2016

So at moment elemental summon is broken if you already had clone. Also probably we need to keep in mind that you may first cast clone on "real" elemental and then summon one.

@ArseniyShestakov

This comment has been minimized.

Copy link
Member Author

ArseniyShestakov commented Mar 1, 2016

Another problem with current code: clones remain visible after original stack is killed. You can't control them though so they look like inactive bitmap. E.g hex is also passable so looks like some rendering issue.

@alexvins alexvins changed the title [WiP] Issues/2304/2418 Issues/2304/2418 Mar 1, 2016
@alexvins

This comment has been minimized.

Copy link
Member

alexvins commented Mar 1, 2016

Feature and re-factoring freeze.

@ArseniyShestakov

This comment has been minimized.

Copy link
Member Author

ArseniyShestakov commented Mar 1, 2016

So now clone stacks disappear only when round is ended so you can able to do weird things with corpse before they disappear. E.g resurrect stack with 0 creatures in it.

@ArseniyShestakov

This comment has been minimized.

Copy link
Member Author

ArseniyShestakov commented Mar 1, 2016

So it's works now. Though there is small text bug:
pr_197_bugtext

Repro:

  • Make clone of stack.
  • Summon first kind of elemental.
  • Attempt to summon different elemental.

So similar to issue 2293.

@ArseniyShestakov

This comment has been minimized.

Copy link
Member Author

ArseniyShestakov commented Mar 1, 2016

Everything else looks fine so we can merge it if text bug can be fixed later on together with one I mentioned.

@alexvins

This comment has been minimized.

Copy link
Member

alexvins commented Mar 1, 2016

Yes, "Gnoll" glitch is same code as 2293, but different bug. However "Gnoll" glitch is a regression so I`ll fix it and may be also 2293 here.

@ArseniyShestakov

This comment has been minimized.

Copy link
Member Author

ArseniyShestakov commented Mar 1, 2016

So I think it's fixed! May be it's time to merge it.

ArseniyShestakov added a commit that referenced this pull request Mar 1, 2016
Issues/2304/2418/2293
@ArseniyShestakov ArseniyShestakov merged commit 7886e89 into develop Mar 1, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ArseniyShestakov ArseniyShestakov deleted the issue/2304_2418 branch Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.