Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accumulated issues with campaigns #2259

Merged
merged 22 commits into from Jun 30, 2023

Conversation

IvanSavenko
Copy link
Member

@IvanSavenko IvanSavenko commented Jun 26, 2023

Progress so far:

  • extract campaign-related code from CGameState
  • reorganize CampaignHandler / CampaignState code
  • rewrite heroes crossover code to match H3 logic
  • fix transfer of artifacts kept by heroes
  • check that game picks strongest heroes (and not weakest) for transfer
  • check that game places heroes by power in same order as in H3
  • recheck removal of reserved heroes

Campaigns that should be tested to confirm functionality of most of edge cases:

  • Spoils of War (player selectable heroes, and even - color to play in 3rd scenario)
  • Armageddon Blade (a lot of hero & artifact transfer shenanigans)
  • Unholy Alliance (a lot of hero & artifact transfer shenanigans)

Issues to confirm and fix:

Postponed (to be moved to separate issue)

  • Asylum (user-made campaign) - Hero placeholder (by type) should be replaced even hero was not owned before
  • Dungeons and Devils, scenario A Devilish Plan - defeating quest monster leads to game over (https://bugs.vcmi.eu/view.php?id=2170)
  • Birth of Barbarian - has "if you lose either component of the Angelic Alliance, the scenario is lost" as additional loss condition
  • New Beginning, Unholy Alliance - Gem has her class set to "Sorceress"

@IvanSavenko IvanSavenko added this to the Release 1.3 milestone Jun 26, 2023
@dydzio0614
Copy link
Member

dydzio0614 commented Jun 26, 2023

while you are at it, dragon slayer campaign should be tested for creatures carryover from 1st mission

@IvanSavenko
Copy link
Member Author

@dydzio0614
Fixed discovered regression with creatures transfer like 5-10 minutes ago. Can confirm that it works on this branch

@IvanSavenko IvanSavenko force-pushed the campaign_refactoring branch 4 times, most recently from 5f9d16f to 520fb9e Compare June 26, 2023 16:02
@IvanSavenko IvanSavenko marked this pull request as ready for review June 27, 2023 17:09
@IvanSavenko
Copy link
Member Author

Presumably complete.

Few campaigns still have few minor issues to solve, but those are not trivial to fix, will move them to separate issues after merge

@IvanSavenko IvanSavenko merged commit 9cd246a into vcmi:develop Jun 30, 2023
11 checks passed
@IvanSavenko IvanSavenko deleted the campaign_refactoring branch June 30, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment