New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix accumulated issues with campaigns #2259
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while you are at it, dragon slayer campaign should be tested for creatures carryover from 1st mission |
@dydzio0614 |
Such as granting Mages Guild Level 4 when town does not have Mages Guild Level 1
IvanSavenko
force-pushed
the
campaign_refactoring
branch
4 times, most recently
from
June 26, 2023 16:02
5f9d16f
to
520fb9e
Compare
IvanSavenko
force-pushed
the
campaign_refactoring
branch
from
June 26, 2023 16:44
520fb9e
to
3d66455
Compare
This was
linked to
issues
Jun 27, 2023
This was
linked to
issues
Jun 27, 2023
Closed
Presumably complete. Few campaigns still have few minor issues to solve, but those are not trivial to fix, will move them to separate issues after merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress so far:
Campaigns that should be tested to confirm functionality of most of edge cases:
Issues to confirm and fix:
(https://bugs.vcmi.eu/view.php?id=1695)
Postponed (to be moved to separate issue)