New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake: add NSIS generator settings #29
Conversation
|
There is problem. Different versions of HoMM3 (NWC/3DO, GOG.com, Buka) use different registry keys. GOG.com (Probably 3DO too)
Buka
|
I think vcmi should first look into data path in config if it is not set then pull registry and if nothing found may be try also vcmi installation path. If data was found, save path in config or complain and return otherwise. |
@alexvins Using search like this is a good idea but player still must select preferred data - in case of multiple installs for example. |
I think it is task for another pull request. |
Yes. Then I'll update my first comment here:
If you wish to keep both of these as it - I'm OK with that, just want to hear your opinion on these. |
fixed
Uh. This is non-trivial to do with CPack and NSIS. I think it's better to leave it as is |
Ok, merged. Any volunteers to implement data directory selection for Launcher? EDIT: created issue on Mantis, to keep this tracked: http://bugs.vcmi.eu/view.php?id=1845 |
CMake: add NSIS generator settings
I'm trying to do it. |
How-to build:
cpack -G NSIS
cpack -G ZIP
Output format:
vcmi-x.xx-win32.(exe|zip)
Example:
vcmi-0.96-win32.exe