add vcmibuilder version check for innoextract #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… current GOG package
|
I don't get why this |
|
fixed the commented issue; do you know why is that travis takes so long to start the mac build? |
|
Travis usually takes long on Mac builds mainly because we commit a lot and they have limited Mac instances pool. Regardless it's not required for this to be merged since we don't really expose it on macOS. |
|
Sorry for taking long to merge this, had to check that innoextract on 14.04(1.4) and 16.04 (1.5) in fact use same version output. Thanks for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add vcmibuilder check for the old innoextract is unable to unpack the latest GOG package