add internal/db/rdb/mysql/model test #628

vankichi · 2020-08-17T08:04:16Z

Signed-off-by: vankichi kyukawa315@gmail.com

Description:

create test for internal/db/rdb/mysql/model.go
add comment each function/exported variables for internal/db/rdb/mysql/model.go

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.14.4
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.12.0

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

pull-assistant · 2020-08-17T08:04:18Z

Best reviewed: commit by commit

Optimal code review plan

✅ add internal/db/rdb/mysql/model test

✅ fix

Update internal/db/rdb/mysql/model_test.go

🤖 Update license headers / Format go codes and yaml files

Powered by Pull Assistant. Last update 28132cc ... 0a3123f. Read the comment docs.

vdaas-ci · 2020-08-17T08:04:35Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master

internal/db/rdb/mysql/model_test.go

codecov · 2020-08-18T06:39:23Z

Codecov Report

Merging #628 into master will increase coverage by 2.01%.
The diff coverage is 10.70%.

@@            Coverage Diff             @@
##           master     #628      +/-   ##
==========================================
+ Coverage   12.19%   14.20%   +2.01%     
==========================================
  Files         409      408       -1     
  Lines       21340    21456     +116     
==========================================
+ Hits         2602     3048     +446     
+ Misses      18454    18136     -318     
+ Partials      284      272      -12

Impacted Files	Coverage Δ
internal/compress/gzip_option.go	`84.61% <ø> (+15.38%)`	⬆️
internal/compress/lz4_option.go	`84.61% <ø> (+15.38%)`	⬆️
internal/compress/zstd_option.go	`81.81% <ø> (ø)`
internal/db/kvs/redis/option.go	`100.00% <ø> (+91.42%)`	⬆️
internal/db/rdb/mysql/option.go	`100.00% <ø> (+95.34%)`	⬆️
internal/errors/net.go	`0.00% <ø> (ø)`
internal/info/info.go	`29.16% <ø> (ø)`
internal/worker/queue_option.go	`100.00% <ø> (+84.21%)`	⬆️
pkg/tools/cli/loadtest/assets/loader.go	`0.00% <0.00%> (ø)`
pkg/tools/cli/loadtest/config/config.go	`0.00% <0.00%> (ø)`
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95fb5c5...0a3123f. Read the comment docs.

kevindiu

LGTM

internal/db/rdb/mysql/model_test.go

hlts2

LGTM

vankichi · 2020-08-18T12:40:14Z

/rebase
/format
/approve

vdaas-ci · 2020-08-18T12:40:48Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/db/rdb-mysql-model

Signed-off-by: vankichi <kyukawa315@gmail.com>

Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>

vdaas-ci · 2020-08-18T12:41:45Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

Signed-off-by: vdaas-ci <ci@vdaas.org>

vdaas-ci

[APPROVED] This PR is approved by vankichi.

vankichi requested review from kevindiu and hlts2 August 17, 2020 08:04

github-actions bot added area/internal team/set SET team size/L type/test Adding tests priority/low labels Aug 17, 2020

github-actions bot reviewed Aug 17, 2020

View reviewed changes

internal/db/rdb/mysql/model_test.go Show resolved Hide resolved

kevindiu previously approved these changes Aug 18, 2020

View reviewed changes

hlts2 requested changes Aug 18, 2020

View reviewed changes

vankichi dismissed kevindiu’s stale review via c96881f August 18, 2020 12:08

kevindiu previously approved these changes Aug 18, 2020

View reviewed changes

hlts2 previously approved these changes Aug 18, 2020

View reviewed changes

vankichi and others added 10 commits August 18, 2020 12:40

✅ add internal/db/rdb/mysql/model test

28132cc

Signed-off-by: vankichi <kyukawa315@gmail.com>

✅ fix

8253c74

Signed-off-by: vankichi <kyukawa315@gmail.com>

Update internal/db/rdb/mysql/model_test.go

a3e2493

Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>

Update internal/db/rdb/mysql/model_test.go

127c9b2

Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>

Update internal/db/rdb/mysql/model_test.go

4efe3b3

Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>

Update internal/db/rdb/mysql/model_test.go

5ad2ce1

Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>

Update internal/db/rdb/mysql/model_test.go

79857f9

Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>

Update internal/db/rdb/mysql/model_test.go

f0edc01

Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>

Update internal/db/rdb/mysql/model_test.go

9216589

Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>

Update internal/db/rdb/mysql/model_test.go

3d0af7b

Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>

vdaas-ci dismissed stale reviews from hlts2 and kevindiu via 3d0af7b August 18, 2020 12:40

vdaas-ci force-pushed the test/internal/db/rdb-mysql-model branch from 2b7e836 to 3d0af7b Compare August 18, 2020 12:40

🤖 Update license headers / Format go codes and yaml files

0a3123f

Signed-off-by: vdaas-ci <ci@vdaas.org>

vdaas-ci approved these changes Aug 18, 2020

View reviewed changes

vankichi merged commit cd8be5b into master Aug 18, 2020

vankichi deleted the test/internal/db/rdb-mysql-model branch August 18, 2020 13:06

vdaas-ci mentioned this pull request Sep 2, 2020

[patch] update deps #660

Merged

18 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add internal/db/rdb/mysql/model test #628

add internal/db/rdb/mysql/model test #628

vankichi commented Aug 17, 2020

pull-assistant bot commented Aug 17, 2020 •

edited

Loading

vdaas-ci commented Aug 17, 2020

codecov bot commented Aug 18, 2020 •

edited

Loading

kevindiu left a comment

hlts2 left a comment

vankichi commented Aug 18, 2020

vdaas-ci commented Aug 18, 2020

vdaas-ci commented Aug 18, 2020

vdaas-ci left a comment

add internal/db/rdb/mysql/model test #628

add internal/db/rdb/mysql/model test #628

Conversation

vankichi commented Aug 17, 2020

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

pull-assistant bot commented Aug 17, 2020 • edited Loading

vdaas-ci commented Aug 17, 2020

codecov bot commented Aug 18, 2020 • edited Loading

Codecov Report

kevindiu left a comment

Choose a reason for hiding this comment

hlts2 left a comment

Choose a reason for hiding this comment

vankichi commented Aug 18, 2020

vdaas-ci commented Aug 18, 2020

vdaas-ci commented Aug 18, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

pull-assistant bot commented Aug 17, 2020 •

edited

Loading

codecov bot commented Aug 18, 2020 •

edited

Loading