Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts on Present Version #222

Closed
colah opened this issue Jun 29, 2018 · 6 comments
Closed

Thoughts on Present Version #222

colah opened this issue Jun 29, 2018 · 6 comments

Comments

@colah
Copy link
Member

colah commented Jun 29, 2018

Hi All!

I just went over the article again. It's looking great! I had a few small comments. Note that these aren't Distill editorial feedback, and you aren't obligated to take any of it.

  • I was skeptical about the collapsible sections, but I'm coming around! :)

  • While rereading, I was struck that the video example from Charade could potentially be perceived as making a gender stereotype (ie. "women are prone to nervous breakdowns"). I feel like I'm not super calibrated on this kind of thing, and I realize you're working in a lot of constraints, like making it public domain and that you already had to switch it once before... But if it's convenient to swap out, you might consider doing so.

image

  • A couple ideas for sharpening the (very interesting!) section on comparing FILM parameters of feature maps:
    • Used circles to suggest the filters are selectable.
    • Label what the filters are
    • Use one set of labels to filter both plots
    • Sharpen the captioning to make it fast to realize what the difference between the two parts is.
    • (consider also aligning the beta-gamma grids)

image

image

  • The last t-SNE plot seems like it might be broken on drafts (but maybe you've already fixed it and it hasn't rebuilt?)

image

(A couple other thoughts: consider making it possible to hover over the labels rather than just the circles in the legend.)

image

@vdumoulin
Copy link
Contributor

@colah thanks a lot for your feedback!

I'll address it gradually over time, but I think you identified one pressing issue: the Charade still frame. I'm glad that you pointed it out, as I hadn't realized that it could come off as making a gender stereotype (which in hindsight I should have caught sooner). Needless to say, this is definitely not our intention, so I'll find a replacement ASAP.

@arvind
Copy link
Collaborator

arvind commented Jun 29, 2018

The last t-SNE plot seems like it might be broken on drafts (but maybe you've already fixed it and it hasn't rebuilt?)

Aha, I tracked down why this is broken online but working locally.

image

@vdumoulin, I believe github.io supports https (https://ariutta.github.io/svg-pan-zoom/dist/svg-pan-zoom.min.js resolves for me). Alternatively, you could copy the js library into your static folder and reference it from there. I may have a slight preference for the latter to increase future proofing.

@colah
Copy link
Member Author

colah commented Jun 29, 2018

A few more thoughts:

  • Several of the new diagrams could benefit from a bit more labeling and emphasizing key words. This would make them easier to understand as someone quickly skims through. This might also allow you to make the captions a bit shorter. For example:

image

  • Some alternate interfaces for the interpolation stuff:

image

or

image

@fstrub95
Copy link
Contributor

fstrub95 commented Jun 29, 2018 via email

@vdumoulin
Copy link
Contributor

@colah here are new figure designs following your feedback:

image

image

image

image

image

@colah
Copy link
Member Author

colah commented Jul 4, 2018

Looks nice! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants