Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine useSearch interface #51

Open
cjcenizal opened this issue Mar 8, 2024 · 0 comments
Open

Refine useSearch interface #51

cjcenizal opened this issue Mar 8, 2024 · 0 comments

Comments

@cjcenizal
Copy link
Contributor

cjcenizal commented Mar 8, 2024

This hook currently returns { fetchSearchResults, isLoading }. I noticed two things:

  • We're using two different verbs to describe the same action: "fetch" and "load"
  • The action is verbose but the state is terse

I think we can reconcile these differences and create more symmetry between the action and the state. I suggest erring on the side of verbosity to avoid potential conflicts with the consumer's variables, e.g. a local isLoading variable. I'd suggest { fetchSearchResults, isFetchingSearchResults }.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant