Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EA: Use 3PID capability to show / hide email UI in settings for MSC3824 OIDC-aware #8615

Closed
hughns opened this issue Aug 18, 2023 · 1 comment · Fixed by #8618
Closed

EA: Use 3PID capability to show / hide email UI in settings for MSC3824 OIDC-aware #8615

hughns opened this issue Aug 18, 2023 · 1 comment · Fixed by #8618
Assignees

Comments

@hughns
Copy link
Member

hughns commented Aug 18, 2023

Element Android was previously made "OIDC-aware" (as described by MSC3824).

When the homeserver is configured in MSC3861 delegated OIDC mode (e.g. to MAS) the user needs to add and remove 3pids via the UI provided by MAS.

As such, Element Android should check the capability that instructs clients whether or not they can manage 3PIDs: https://spec.matrix.org/v1.7/client-server-api/#m3pid_changes-capability

If the capability is not set to true then the client should hide the UI for managing emails.

n.b. the Identity Server functionality should remain the same as today.

@hughns hughns changed the title Use 3PID capability to show / hide email UI in settings for MSC3824 OIDC-aware EA: Use 3PID capability to show / hide email UI in settings for MSC3824 OIDC-aware Aug 18, 2023
@bmarty bmarty self-assigned this Aug 21, 2023
@bmarty
Copy link
Member

bmarty commented Aug 21, 2023

@hughns about your requirement:

If the capability is not set to true then the client should hide the UI for managing emails.

it is conflicting with the spec:

When not listed, clients should assume the user is able to modify their 3PID associations.

This behavior is already implemented: https://github.com/vector-im/element-android/blob/develop/matrix-sdk-android/src/main/java/org/matrix/android/sdk/internal/session/homeserver/GetHomeServerCapabilitiesTask.kt#L133

What is missing is the hiding of the settings, I will create a PR about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants