Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcuts with remapped + or - key don't work on wayland (desktop) #794

Open
nidico opened this issue Apr 15, 2021 · 4 comments
Open

Shortcuts with remapped + or - key don't work on wayland (desktop) #794

nidico opened this issue Apr 15, 2021 · 4 comments

Comments

@nidico
Copy link

nidico commented Apr 15, 2021

The zoom-out shortcut (ctrl-minus) doesn't have any effect when running element-desktop 1.7.25 on wayland (which is possible since 1.7.25, see element-hq/element-web#15725). Zoom-in (ctrl-plus) and zoom-default (ctrl-0) do work. All three shortcuts work fine with element-desktop on xwayland.

System: Debian testing with sway (1.6)
Element version: 1.7.25 (desktop)

@nidico
Copy link
Author

nidico commented Apr 15, 2021

I've looked into this a bit more:

This only happens on my custom keyboard layout where - is remapped (through a custom xkb keymap) to the <BKSL> key which doesn't exist on US keyboards. If it's mapped to another key (or not at all) there isn't any issue. If plus is mapped to the <BKSL> key, ctrl-+ doesn't work, so this is definitely the culprit.

Also, there is no issue when using xwayland, so it seems like electron on wayland is using some other means to query key presses than xwayland.

I'll check further later and - if confirmed - report the findings on electron upstream.

@nidico nidico changed the title Zoom out (ctrl-minus) doesn't work on wayland (desktop) Shortcuts with keys mapped to <BKSL> don't work on wayland (desktop) Apr 15, 2021
@nidico
Copy link
Author

nidico commented Apr 15, 2021

I was wrong above (and tested with xwayland at some point). As soon as - or + are remapped to a non-default key (no matter to which key), shortcuts involving those keys don't work anymore. This does not happen if 0 is remapped (i.e. ctrl+0 still works).

@nidico nidico changed the title Shortcuts with keys mapped to <BKSL> don't work on wayland (desktop) Shortcuts with remapped + or - key don't work on wayland (desktop) Apr 15, 2021
@yajo
Copy link

yajo commented Jun 30, 2021

I'm using X11 (not wayland) and, since today, I cannot use Ctrl++ as I'm used to, to zoom in.

I can use the workaround of clicking on the option in the menu bar, so it's not very critical, but I wonder why I was able to use this since forever and not since today.

  • This is how the menu looks for the workaround:
    image

  • Other shortcuts such as Ctrl+- or Ctrl+0 work as expected.

  • Version of Element: 1.7.31

  • Version of olm: 3.2.3

  • Installed from flathub.org

  • Fedora 34 Silverblue

@jplatte
Copy link

jplatte commented Apr 27, 2022

I have the same issue as @yajo regardless of whether I use Electron's wayland or x11 (via xwayland) backend. This only happens with the plus key next to Enter, I was able to zoom in with Ctrl+NumpadPlus.

@t3chguy t3chguy transferred this issue from element-hq/element-web Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants