Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We don't handle 403s on rooms gracefully #18

Closed
ara4n opened this issue Aug 29, 2015 · 2 comments
Closed

We don't handle 403s on rooms gracefully #18

ara4n opened this issue Aug 29, 2015 · 2 comments
Labels
A-Invite O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Aug 29, 2015

erikj (IRC)Dave: We don't seem to be handling 403s gracefully

2:02:36 PM
as in, I am now stuck on the spinner because it got fonxed trying to get pushrules
[13:08] Arathorn kegan: matrix-js-sdk seems to tightloop on
[13:08] Arathorn https://matrix.org//_matrix/client/api/v1/rooms/!lEZougoyUxdyEUlrFY%3Amatri…imit=20&dir=b&access_token= net::ERR_NAME_NOT_RESOLVED run_xhr @ index.js:218
[13:08] Arathorn if i remove netaccess
[13:08] Arathorn e.g. by VPNing
[13:10] kegan the js sdk does not automatically retry scrollback
[13:12] Arathorn okay, so it must be being triggered by trying to infinite scroll when you have no net access

...also...

If i'm kicked from a room, i can still try to send to it. JS console stacks up with loads of:
Failed to load resource: the server responded with a status of 403 (Forbidden)
q.js:161 Uncaught M_FORBIDDEN: User @matthew:matrix.org not in room !OkPeYYmtiSfwzDbCsg:matrix.org (<FrozenEvent event_id='$14375444627737xXjLH:matrix.org', type='m.room.member', state_key='@matthew:matrix.org'>)

@ara4n ara4n added the T-Defect label Aug 29, 2015
@ara4n ara4n modified the milestone: Ragnarok Nov 29, 2015
@richvdh
Copy link
Member

richvdh commented Mar 7, 2016

See also #979, which is the same thing as applied to per-event links

@ara4n ara4n removed this from the Ragnarok milestone Apr 13, 2016
dtygel pushed a commit to coletivoEITA/riot-web that referenced this issue May 5, 2017
@richvdh richvdh changed the title We don't handle 403s gracefully We don't handle 403s on rooms gracefully Oct 31, 2017
@andybalaam andybalaam added S-Minor Impairs non-critical functionality or suitable workarounds exist A-Invite O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed P3 labels Nov 25, 2022
@t3chguy
Copy link
Member

t3chguy commented Oct 4, 2024

Cannot reproduce this on latest, please open a new issue with logs if it recurs

@t3chguy t3chguy closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2024
t3chguy pushed a commit that referenced this issue Oct 17, 2024
Co-authored-by: dbkr <986903+dbkr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Invite O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

4 participants