Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiment with putting threads back behind a beta toggle #25676

Open
1 of 2 tasks
Tracked by #24392
Johennes opened this issue Jun 28, 2023 · 9 comments
Open
1 of 2 tasks
Tracked by #24392

Experiment with putting threads back behind a beta toggle #25676

Johennes opened this issue Jun 28, 2023 · 9 comments
Labels
A-Notifications A-Threads T-Task Tasks for the team like planning

Comments

@Johennes
Copy link
Contributor

Johennes commented Jun 28, 2023

Threads are one of the main drivers of #24392. Purely as an experiment, it would be helpful to compare the notification experience on Element Web with threads enabled to a state where threads are turned off and use the reply fallback when rendering.

This has been prototyped in matrix-org/matrix-react-sdk#11151.

Issues found on the deployment are tracked below.

Issues

@thibaultamartin
Copy link
Contributor

Is this available in the latest Nightly? I couldn't find it in settings :)

@weeman1337
Copy link
Contributor

Is this available in the latest Nightly? I couldn't find it in settings :)

matrix-org/matrix-react-sdk#11151 is a draft PR → not available on nightly . But to test it you can use the PR deployment.

@robintown robintown added T-Task Tasks for the team like planning A-Notifications A-Threads labels Jun 28, 2023
@Johennes
Copy link
Contributor Author

@thibaultamartin had you noticed any other issues not already listed above on the deployment yesterday?

@thibaultamartin
Copy link
Contributor

A regular issue I face with threads and stuck notifications is that restarting Element (or rather: updating my Nightly) "re-sticks" notifications that were unstuck.

For example the main channel I use has no notifications left (usually after being cleared with "Mark as unread"), and when I update it's back to ~20 unread notifications

@Johennes
Copy link
Contributor Author

Do you mean you see that on normal / nightly Element? Or on the deployment with threads turned off?

@thibaultamartin
Copy link
Contributor

Oh my apologies I meant regular Nightly, I didn't have the time to try the experimental deployment yet! I will give it a go today

@Johennes
Copy link
Contributor Author

Re-tested on the updated deployment today and, unfortunately, the two issues listed above still persist.

@johanricher
Copy link

johanricher commented Feb 7, 2024

Thank you for considering making the Threads feature optional (via a toggle). My intuition is that a lot of problems related to stuck notifications are caused by Threads.

Is the current understanding of the dev team that disabling Threads doesn't / wouldn't help with stuck notifications?

@t3chguy
Copy link
Member

t3chguy commented Feb 12, 2024

@johanricher last time we discussed it we concluded that a significant portion of stuck notification issues relate to threads, but not certain that turning them off would undo the damage and also were unable to get buy-in from the Product/Management teams to disable threads.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Notifications A-Threads T-Task Tasks for the team like planning
Projects
None yet
Development

No branches or pull requests

6 participants