Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.mx_MessagePanel_myReadMarker has invalid css #27482

Closed
IceMinePenguin opened this issue May 16, 2024 · 2 comments · Fixed by matrix-org/matrix-react-sdk#12772
Closed

.mx_MessagePanel_myReadMarker has invalid css #27482

IceMinePenguin opened this issue May 16, 2024 · 2 comments · Fixed by matrix-org/matrix-react-sdk#12772
Assignees
Labels
A-Read-Marker Green line showing how far _you_ have read A-Themes-Custom Custom theme variables or support O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs

Comments

@IceMinePenguin
Copy link

Steps to reproduce

I was creating a custom theme for element web. I noticed the unread bar that appears when you go into a room with unread messages wasn't themed correctly. I opened the inspector and found the css. it is trying to set the color to "--accent" which doesn't exist, so it falls back to green.

image

Outcome

What did you expect?

I would expect the element to either use --accent-color or for --accent to exist and the style to not fall back to the default green.

What happened instead?

It is referencing a variable that does not exist.

Operating system

Arch Linux

Browser information

Firefox 125.0.3-2

URL for webapp

Private self hosted instance,

Application version

Version 1.11.60

Homeserver

Private homeserver, Synapse, 1.102.0

Will you send logs?

No

@dosubot dosubot bot added A-Themes-Custom Custom theme variables or support S-Minor Impairs non-critical functionality or suitable workarounds exist labels May 16, 2024
@MidhunSureshR MidhunSureshR removed the A-Themes-Custom Custom theme variables or support label May 20, 2024
@github-actions github-actions bot removed the Z-Labs label May 20, 2024
@MidhunSureshR MidhunSureshR added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience Z-Labs A-Read-Marker Green line showing how far _you_ have read X-Cannot-Reproduce and removed Z-Labs labels May 20, 2024
@MidhunSureshR
Copy link
Member

Works fine for me:
image

accent (defined here) is replaced by the compound variable.

@t3chguy
Copy link
Member

t3chguy commented May 23, 2024

@MidhunSureshR --accent and $accent are not the same. The latter is inlined at build time given it is a pcss variable.

image

This looks specific to the custom theme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Read-Marker Green line showing how far _you_ have read A-Themes-Custom Custom theme variables or support O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Z-Labs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants