Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardise how a room converted to a DM shows events in room list preview #1548

Open
kittykat opened this issue Oct 2, 2023 · 3 comments
Open

Standardise how a room converted to a DM shows events in room list preview #1548

kittykat opened this issue Oct 2, 2023 · 3 comments
Labels
A-Room List O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@kittykat
Copy link
Contributor

kittykat commented Oct 2, 2023

Steps to reproduce

  1. Create a room
  2. Convert to DM
  3. Send location or poll

Outcome

What did you expect?

Both platforms show the same preview for the event

What happened instead?

EX Android shows: "username: event" in the room list preview
EX iOS shows: "event" in the room list preview

Application version

Nightly

Homeserver

matrix.org
@kittykat kittykat added A-Room-List X-Needs-Product Issue needs input from Product team labels Oct 2, 2023
@VolkerJunginger
Copy link

iOS is right. A dm is meant to be a conversation between max two users so there is no need to show the username.

@VolkerJunginger VolkerJunginger removed the X-Needs-Product Issue needs input from Product team label Oct 11, 2023
@kittykat kittykat transferred this issue from element-hq/element-meta Oct 11, 2023
@kittykat kittykat added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Oct 11, 2023
@julioromano julioromano added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Oct 13, 2023
@manuroe manuroe mentioned this issue Nov 28, 2023
Closed
9 tasks
@manuroe manuroe added O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed Z-Schedule O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Jan 17, 2024
@manuroe
Copy link
Member

manuroe commented Jul 4, 2024

@amshakal we need to double the production decision. Android and iOS are doing the opposite of what the description is saying.

@amshakal
Copy link

amshakal commented Jul 9, 2024

We need to not show username in the preview when there are only 2 people there. It gets tricky when bots are there in a DM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Room List O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kittykat @julioromano @bmarty @manuroe @amshakal @VolkerJunginger