Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regex: Fixes Permalink action on timeline #303

Merged
merged 7 commits into from
Nov 9, 2022
Merged

Regex: Fixes Permalink action on timeline #303

merged 7 commits into from
Nov 9, 2022

Conversation

ismailgulek
Copy link
Contributor

Also adds some tests.

@github-actions
Copy link

github-actions bot commented Nov 9, 2022 •
edited
Loading

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against 10656f2

stefanceriu
stefanceriu approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👌 👌

@ismailgulek ismailgulek enabled auto-merge (squash) November 9, 2022 09:24
@sonarcloud
Copy link

sonarcloud bot commented Nov 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ismailgulek ismailgulek merged commit 6c6c188 into develop Nov 9, 2022
@ismailgulek ismailgulek deleted the ismail/regex_fixes branch November 9, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefanceriu stefanceriu stefanceriu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ismailgulek @stefanceriu