Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry decryption encrypted timeline item debug menu option #384

Merged
merged 6 commits into from
Dec 22, 2022

Conversation

stefanceriu
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Dec 21, 2022

Warnings
⚠️ Please provide a description for this PR.
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against fd12331

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Base: 42.52% // Head: 42.45% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (d79d639) compared to base (131197b).
Patch coverage: 28.84% of modified lines in pull request are covered.

❗ Current head d79d639 differs from pull request most recent head fd12331. Consider uploading reports for the commit fd12331 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #384      +/-   ##
===========================================
- Coverage    42.52%   42.45%   -0.08%     
===========================================
  Files          248      248              
  Lines        14124    14157      +33     
  Branches      8297     8392      +95     
===========================================
+ Hits          6006     6010       +4     
- Misses        7880     7904      +24     
- Partials       238      243       +5     
Flag Coverage Δ
unittests 19.17% <6.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eens/RoomScreen/View/TimelineItemContextMenu.swift 0.00% <0.00%> (ø)
ElementX/Sources/Services/Room/MockRoomProxy.swift 0.00% <ø> (ø)
ElementX/Sources/Services/Room/RoomProxy.swift 0.00% <0.00%> (ø)
...entX/Sources/Services/Room/RoomProxyProtocol.swift 0.00% <0.00%> (ø)
...ervices/Room/RoomSummary/RoomSummaryProvider.swift 0.00% <0.00%> (ø)
...s/Services/Timeline/MockRoomTimelineProvider.swift 0.00% <ø> (ø)
...urces/Services/Timeline/RoomTimelineProvider.swift 0.00% <0.00%> (ø)
...rvices/Timeline/RoomTimelineProviderProtocol.swift 0.00% <ø> (ø)
...ne/TimelineController/RoomTimelineController.swift 0.00% <0.00%> (ø)
...urces/Screens/RoomScreen/RoomScreenViewModel.swift 34.19% <56.25%> (-0.15%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@paleksandrs paleksandrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me 👍🏼 just one small suggestion, up to you if you want to use it

@sonarcloud
Copy link

sonarcloud bot commented Dec 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stefanceriu stefanceriu merged commit ac77743 into develop Dec 22, 2022
@stefanceriu stefanceriu deleted the stefan/decryptionRetrying branch December 22, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants