Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User sessions tests #390

Merged
merged 2 commits into from
Jan 6, 2023
Merged

User sessions tests #390

merged 2 commits into from
Jan 6, 2023

Conversation

paleksandrs
Copy link
Contributor

Unit tests for UserSession

@github-actions
Copy link

github-actions bot commented Dec 23, 2022

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.
⚠️ Please add a sign-off to either the PR description or to the commits themselves.

Generated by 🚫 Danger Swift against e23c8f3

@codecov
Copy link

codecov bot commented Dec 23, 2022

Codecov Report

Base: 43.41% // Head: 43.65% // Increases project coverage by +0.24% 🎉

Coverage data is based on head (e23c8f3) compared to base (34eb835).
Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #390      +/-   ##
===========================================
+ Coverage    43.41%   43.65%   +0.24%     
===========================================
  Files          248      248              
  Lines        14128    14128              
  Branches      8502     8502              
===========================================
+ Hits          6133     6168      +35     
+ Misses        7767     7731      -36     
- Partials       228      229       +1     
Flag Coverage Δ
unittests 20.84% <ø> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...entX/Sources/Services/Client/MockClientProxy.swift 28.57% <0.00%> (ø)
...ation/MockSessionVerificationControllerProxy.swift 100.00% <100.00%> (ø)
...lementX/Sources/Services/Session/UserSession.swift 78.48% <0.00%> (+44.30%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pixlwave pixlwave force-pushed the aleksandrs/295_user_session_tests branch from a777841 to e875bfd Compare January 5, 2023 18:02
@pixlwave pixlwave requested review from pixlwave and removed request for stefanceriu January 5, 2023 18:17
paleksandrs and others added 2 commits January 6, 2023 10:31
- Merge SessionVerificationControllerProxyMock into MockSessionVerificationControllerProxy.
- Merge ClientProxyMock into MockClientProxy.
- Simplify naming.
@pixlwave pixlwave force-pushed the aleksandrs/295_user_session_tests branch from 0e3d798 to e23c8f3 Compare January 6, 2023 10:32
@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pixlwave pixlwave merged commit bf9b823 into develop Jan 6, 2023
@pixlwave pixlwave deleted the aleksandrs/295_user_session_tests branch January 6, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants