Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes. #406

Merged
merged 2 commits into from
Jan 5, 2023
Merged

Minor fixes. #406

merged 2 commits into from
Jan 5, 2023

Conversation

pixlwave
Copy link
Member

@pixlwave pixlwave commented Jan 5, 2023

A couple of minor tweaks:

  • Use the links colour from Compound for links.
  • Avoid constantly recomputing the RoomScreen view hierarchy while scrolling.

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

Warnings
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.
⚠️ You seem to have made changes to views. Please consider adding screenshots.

Generated by 🚫 Danger Swift against 64b15a6

Copy link
Member

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@sonarcloud
Copy link

sonarcloud bot commented Jan 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 42.61% // Head: 42.56% // Decreases project coverage by -0.05% ⚠️

Coverage data is based on head (64b15a6) compared to base (fd42bee).
Patch coverage: 12.50% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #406      +/-   ##
===========================================
- Coverage    42.61%   42.56%   -0.06%     
===========================================
  Files          248      248              
  Lines        14074    14091      +17     
  Branches      8444     8454      +10     
===========================================
  Hits          5998     5998              
- Misses        7855     7872      +17     
  Partials       221      221              
Flag Coverage Δ
unittests 19.16% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../RoomScreen/View/TimelineTableViewController.swift 0.00% <0.00%> (ø)
...s/RoomScreen/View/Timeline/FormattedBodyText.swift 36.04% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pixlwave pixlwave merged commit 530ae33 into develop Jan 5, 2023
@pixlwave pixlwave deleted the doug/tweaks branch January 5, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants