Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New timeline items #424

Merged
merged 5 commits into from
Jan 9, 2023
Merged

New timeline items #424

merged 5 commits into from
Jan 9, 2023

Conversation

stefanceriu
Copy link
Member

@stefanceriu stefanceriu commented Jan 6, 2023 •
edited
Loading

  • Add support for new timeline items: loading indicators, stickers and invalid/unsupported events
  • cleanup the session verification state machine
  • rename TimelineItemInGroupState -> TimelineItemGroupState

Screenshot 2023-01-06 at 16 38 42

Screenshot 2023-01-06 at 16 38 00

Screenshot 2023-01-06 at 17 02 08

@github-actions
Copy link

github-actions bot commented Jan 6, 2023 •
edited
Loading

Warnings
⚠️ This pull request seems relatively large. Please consider splitting it into multiple smaller ones.
⚠️ Some of the commits are missing ticket numbers. Please consinder using them for better tracking.

Generated by 🚫 Danger Swift against 5220b8e

@jplatte
Copy link
Contributor

jplatte commented Jan 6, 2023

unsupported events

Note, FailedToParse does not mean unsupported, it means the event content couldn't be deserialized to one of Ruma's event types - could be intentionally invalid content from a malicious client, a Ruma bug, a client bug or (which seems to be the case here) a server bug.

@stefanceriu
Copy link
Member Author

Yep, I understand. I just added the unsupported view representation as a catch all until we need to split them up more.

pixlwave
pixlwave approved these changes Jan 6, 2023
View reviewed changes
Copy link
Member

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, more types 👏

ElementX/Sources/Services/Timeline/TimelineItems/Items/ReadMarkerRoomTimelineItem.swift Show resolved Hide resolved
ElementX/Sources/Screens/RoomScreen/View/TimelineTableViewController.swift Show resolved Hide resolved
ElementX/Sources/Screens/RoomScreen/View/Timeline/UnsupportedRoomTimelineView.swift Outdated Show resolved Hide resolved
ElementX/Sources/Services/Timeline/TimelineItems/RoomTimelineItemFactory.swift Show resolved Hide resolved
@stefanceriu
Add support for the new TimelineStart timeline item and new paginatio…
6fe95a0 
…n API. Remove identifiers from individual timeline items and only set them in the TimelineTableViewController
@stefanceriu stefanceriu marked this pull request as ready for review January 9, 2023 15:16
@stefanceriu stefanceriu merged commit ae8e7f4 into stefan/sessionVerificationManualStart Jan 9, 2023
@stefanceriu stefanceriu deleted the stefan/newTimelineItems branch January 9, 2023 15:17
@sonarcloud
Copy link

sonarcloud bot commented Jan 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.7% 3.7% Duplication

stefanceriu added a commit that referenced this pull request Jan 10, 2023
@stefanceriu
New timeline items (#424)
cc20e7e 
* Cleanup session verification state machine configuration

* Add support for new timeline items: loading indicators, stickers and invalid/unsupported events

* Add sticker accessibility label, fix session verification ones

* Add support for the new TimelineStart timeline item and new pagination API. Remove identifiers from individual timeline items and only set them in the TimelineTableViewController

* Add changelog
stefanceriu added a commit that referenced this pull request Jan 10, 2023
@stefanceriu
New timeline items (#424)
d91c05e 
* Cleanup session verification state machine configuration

* Add support for new timeline items: loading indicators, stickers and invalid/unsupported events

* Add sticker accessibility label, fix session verification ones

* Add support for the new TimelineStart timeline item and new pagination API. Remove identifiers from individual timeline items and only set them in the TimelineTableViewController

* Add changelog
stefanceriu added a commit that referenced this pull request Jan 10, 2023
@stefanceriu
New timeline items (#424)
d70a240 
* Cleanup session verification state machine configuration

* Add support for new timeline items: loading indicators, stickers and invalid/unsupported events

* Add sticker accessibility label, fix session verification ones

* Add support for the new TimelineStart timeline item and new pagination API. Remove identifiers from individual timeline items and only set them in the TimelineTableViewController

* Add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pixlwave pixlwave pixlwave approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanceriu @jplatte @pixlwave