Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Favicon icon doesn't change to red anymore #11347

Closed
turt2live opened this issue Nov 7, 2019 · 4 comments · Fixed by #11375
Closed

Favicon icon doesn't change to red anymore #11347

turt2live opened this issue Nov 7, 2019 · 4 comments · Fixed by #11375
Assignees
@turt2live
Labels
T-Defect X-Regression

Comments

@turt2live
Copy link
Member

Mine is stuck as boring R, despite the title having [1] or even [12]
@turt2live
Copy link
Member Author

the room list, timeline, etc are all fine - it's just the R in the tab.

@jryans jryans added the T-Defect label Nov 8, 2019
@turt2live turt2live self-assigned this Nov 8, 2019
@turt2live
Copy link
Member Author

I can't reproduce this anymore, so closing.

@turt2live
Copy link
Member Author

I have a reproduction case:

  1. Be sitting in a room that is not the one you're about to be pinged in.
  2. Make sure the room you're receiving a message in is a DM (or possibly an 'All Messages' room, without ping)
  3. Switch to another tab
  4. Have the other party send a message (without ping)
  5. Number updates, noise plays, favicon stays the same.

Chrome 78 on Windows 10.

@turt2live turt2live reopened this Nov 8, 2019
@turt2live
Copy link
Member Author

Simpler reproduction steps:

  1. Have the badge update
  2. Mark all messages as read
  3. Switch tabs
  4. Receive messages

This is only a problem on Chrome.

turt2live added a commit that referenced this issue Nov 12, 2019
@turt2live
Perform favicon updates twice in Chrome
ec9a38c 
See diff for why this arcane magic is needed.

Fixes #11347
@turt2live turt2live mentioned this issue Nov 12, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turt2live turt2live

Labels
T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Perform favicon updates twice in Chrome element-hq/element-web
2 participants
@jryans @turt2live