Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@ section on username box is 1px too short at the bottom #3738

Closed
dbkr opened this issue Apr 26, 2017 · 4 comments
Closed

@ section on username box is 1px too short at the bottom #3738

dbkr opened this issue Apr 26, 2017 · 4 comments
Labels
P1 S-Tolerable Low/no impact on users T-Defect
Milestone
minor

Comments

@dbkr
Copy link
Member

dbkr commented Apr 26, 2017

No description provided.

@dbkr dbkr added the S-Tolerable Low/no impact on users label Apr 26, 2017
@dbkr
Copy link
Member Author

dbkr commented Apr 26, 2017

screen shot 2017-04-26 at 13 12 05

@lampholder
Copy link
Member

Did this already get changed? I've definitely seen the 1 pixel wonkalonk in the past, but it looks good now in Chrome on Ubuntu, Windows at least.

@lampholder
Copy link
Member

The wonky extra pixel is there on Chrome on Mac. Hoo-ray for browser standards.

@lampholder lampholder added this to the minor milestone Apr 27, 2017
ara4n added a commit that referenced this issue May 15, 2017
@ara4n
fix off-by-one pixel errors in login field heights - fixes #3738
fe61a7e
@ara4n
Copy link
Member

ara4n commented May 15, 2017

fixed by fe61a7e. i really need to give people a crash course in maintainable CSS - the problem here is that we were sizing the box to the font, which inevitably has different sizing on platforms. If we have boxes that we want to line up we have to give them explicit heights.

@ara4n ara4n closed this as completed May 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Milestone
minor
Development

No branches or pull requests
3 participants
@dbkr @ara4n @lampholder