Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invite_room_state is no longer shown on invites #7229

Closed
ara4n opened this issue Aug 28, 2018 · 3 comments
Closed

invite_room_state is no longer shown on invites #7229

ara4n opened this issue Aug 28, 2018 · 3 comments
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression

Comments

@ara4n
Copy link
Member

ara4n commented Aug 28, 2018 •
edited
Loading

When you're invited to a room, we no longer tell you what room you're being invited to. This looks to be a v1/v2(!) regression as per matrix-org/matrix-spec-proposals#1568; just need to inspect the unsigned bit of the event.
ara4n added a commit to matrix-org/matrix-js-sdk that referenced this issue Aug 28, 2018
@ara4n
hopefully fix invite_room_state as per element-hq/element-web#7229
b0b0291
This was referenced Aug 28, 2018
Closed
Closed
@lampholder lampholder added T-Defect ui/ux P1 X-Regression S-Major Severely degrades major functionality or product features, with no satisfactory workaround labels Aug 28, 2018
@ara4n
Copy link
Member Author

ara4n commented Aug 28, 2018

FIXED!

screen shot 2018-08-28 at 18 01 08

@ara4n ara4n closed this as completed Aug 28, 2018
@ara4n
Copy link
Member Author

ara4n commented Aug 28, 2018

...although broke the tests.

@ara4n ara4n reopened this Aug 28, 2018
@ara4n
Copy link
Member Author

ara4n commented Aug 28, 2018 •
edited
Loading

tests fixed in matrix-org/matrix-js-sdk@a6de395

@ara4n ara4n closed this as completed Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ara4n @lampholder