Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new theme API in react-sdk #11442

Merged
merged 1 commit into from Nov 20, 2019
Merged

Use new theme API in react-sdk #11442

merged 1 commit into from Nov 20, 2019

Conversation

@dbkr
Copy link
Member

dbkr commented Nov 20, 2019

A thesis presented in two parts. This part has the absolute minimum
logic changes to the themeing code in vector/index.js because I know
how subtle and fragile this code is. However, it also looks like it's
completely duplicated from react-sdk, so in the next part I'm going
to remove that logic and make it use the logic in react-sdk, then we
can see what breaks.

Requires matrix-org/matrix-react-sdk#3637

A thesis presented in two parts. This part has the absolute minimum
logic changes to the themeing code in vector/index.js because I know
how subtle and fragile this code is. However, it also looks like it's
completely duplicated from react-sdk, so in the next part I'm going
to remove that logic and make it use the logic in react-sdk, then we
can see what breaks.

Requires matrix-org/matrix-react-sdk#3637
@dbkr dbkr requested a review from vector-im/riot-web Nov 20, 2019
@dbkr dbkr mentioned this pull request Nov 20, 2019
@bwindels bwindels requested review from bwindels and removed request for vector-im/riot-web Nov 20, 2019
Copy link
Contributor

bwindels left a comment

lgtm, code doesn't look duplicated though as mentioned in the description?

@dbkr

This comment has been minimized.

Copy link
Member Author

dbkr commented Nov 20, 2019

Well, duplicated code was already there - see #11445

@dbkr dbkr merged commit 135d5f4 into develop Nov 20, 2019
5 checks passed
5 checks passed
buildkite/riot-web Build #1337 passed (10 minutes, 7 seconds)
Details
buildkite/riot-web/eslint-lint Passed (48 seconds)
Details
buildkite/riot-web/i18n Passed (2 minutes, 42 seconds)
Details
buildkite/riot-web/karma-tests Passed (3 minutes, 45 seconds)
Details
buildkite/riot-web/pipeline Passed (3 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.