Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the namespace option on metrics sinks optional #3609

Closed
4 of 5 tasks
binarylogic opened this issue Aug 27, 2020 · 2 comments · Fixed by #3711
Closed
4 of 5 tasks

Make the namespace option on metrics sinks optional #3609

binarylogic opened this issue Aug 27, 2020 · 2 comments · Fixed by #3711
Assignees
@ktff
Labels
domain: metrics Anything related to Vector's metrics events have: must We must have this feature, it is critical to the project's success. It is high priority. sink: prometheus_exporter Anything `prometheus_exporter` sink related type: enhancement A value-adding code change that enhances its existing functionality.
Milestone
2020-08-31 - Digi...

Comments

@binarylogic
Copy link
Contributor

binarylogic commented Aug 27, 2020 •
edited by jamtur01
Loading

Following up on #3519 (comment) and #3609 (comment), we should make the namespace optional on all of the metrics sinks. There are cases where metrics are already prefixed, and therefore, an additional prefix is not needed.

Requirements

  • aws_cloudwatch_metrics sink
  • datadog_metrics sink
  • influxdb_metrics sink
  • prometheus sink
  • statsd sink
@binarylogic binarylogic added type: enhancement A value-adding code change that enhances its existing functionality. sink: prometheus have: must We must have this feature, it is critical to the project's success. It is high priority. domain: metrics Anything related to Vector's metrics events labels Aug 27, 2020
@binarylogic binarylogic mentioned this issue Aug 27, 2020
Merged
@jszwedko
Copy link
Member

jszwedko commented Aug 27, 2020 •
edited
Loading

Just noting that the there are other metric sinks have this as a required field too:

  • aws_cloudwatch_metrics
  • influxdb_metrics
  • statsd
  • datadog_metrics

We may want to consider making it optional there as well. The semantics for those may be different though rather than prometheus which just adds it as a prefix.

Maybe we want to represent the namespace as a first class field on the metric?

https://github.com/timberio/vector/blob/75844bc0f67d24ad1b54bfa130d074810ad2aa50/src/event/metric.rs#L10-L17

Then the sink could decide what to do with it (and maybe we could have an optional default_namespace on the metrics sinks that require it).

@binarylogic binarylogic changed the title Make the namespace option on the prometheus sink optional Make the namespace option on metrics sinks optional Aug 27, 2020
@binarylogic
Copy link
Contributor Author

Updated the description to account for those.

@jszwedko jszwedko mentioned this issue Aug 29, 2020
Merged
@binarylogic binarylogic assigned ktff and unassigned juchiast Aug 31, 2020
This was referenced Aug 31, 2020
Closed
Closed
@ktff ktff mentioned this issue Sep 4, 2020
Merged
1 task
@ktff ktff closed this as completed in #3711 Sep 6, 2020
@binarylogic binarylogic added sink: prometheus_exporter Anything `prometheus_exporter` sink related and removed sink: prometheus labels Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ktff ktff

Labels
domain: metrics Anything related to Vector's metrics events have: must We must have this feature, it is critical to the project's success. It is high priority. sink: prometheus_exporter Anything `prometheus_exporter` sink related type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Milestone
2020-08-31 - Digitization Laser
Development

Successfully merging a pull request may close this issue.

chore: Make the namespace option on metrics sinks optional vectordotdev/vector
4 participants
@jszwedko @binarylogic @ktff @juchiast