Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(operations): Verify building of the Nix package #1432

Merged
7 commits merged into from
Jan 9, 2020
Merged

Conversation

ghost
Copy link

@ghost ghost commented Dec 25, 2019

Closes #1430.

This PR is a draft, as the following items need to be done before merging:

  • Automatically generate cargoSha256.
  • Automatically substitute version from Cargo.toml.
  • Not only build Vector, but also run the tests.

Also, the file distribution/nix/default.nix is an ERB template, but it doesn't have .erb extension because it can't be generated with make generate. I'm not sure is plain nix extension for a template confusing or not.

Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
Signed-off-by: Alexander Rodin <rodin.alexander@gmail.com>
@ghost ghost marked this pull request as ready for review January 6, 2020 13:10
@ghost ghost requested a review from binarylogic as a code owner January 6, 2020 13:10
@ghost
Copy link
Author

ghost commented Jan 6, 2020

This is ready for merging.

@ghost ghost merged commit b0819fd into master Jan 9, 2020
@ghost ghost deleted the verify-nix branch January 9, 2020 11:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build and test NixOS package in CI
1 participant