Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests involving disk buffers fail on NixOS #1503

Closed
ghost opened this issue Jan 9, 2020 · 8 comments
Closed

Tests involving disk buffers fail on NixOS #1503

ghost opened this issue Jan 9, 2020 · 8 comments
Assignees
Labels
domain: buffers Anything related to Vector's memory/disk buffers domain: tests Anything related to Vector's internal tests type: bug A code related bug.

Comments

@ghost
Copy link

ghost commented Jan 9, 2020

Here is an example: https://app.circleci.com/jobs/github/timberio/vector/70981.

It might be related to some recent changes in the buffers, as these tests worked in #1432 on two weeks old master branch.

@ghost ghost added type: bug A code related bug. domain: tests Anything related to Vector's internal tests domain: buffers Anything related to Vector's memory/disk buffers labels Jan 9, 2020
@binarylogic
Copy link
Contributor

@LucioFranco do you mind seeing what's going on here (assuming it's related to recent work?)

@LucioFranco
Copy link
Contributor

@a-rodin do you know how I can reproduce this locally? Seems like just a slow system, that assert I believe relates to total events passed through so unless there was an error I doubt its the disk buffer.

@binarylogic
Copy link
Contributor

@LucioFranco can you try running the tests on the nix docker image? And even if the test is slow, is there a way to deterministically wait for the test to complete?

@LucioFranco
Copy link
Contributor

@binarylogic yeah I can, will do so tomorrow.

@ghost
Copy link
Author

ghost commented Jan 10, 2020

It is possible to run these tests locally in Docker using this command:

./scripts/docker-run.sh verifier-nixos ./scripts/verify-nix.sh

@LucioFranco
Copy link
Contributor

I am having issues with running that command:

[BUG] Bus Error at 0x00007f502bd0ca2c
ruby 2.6.4p104 (2019-08-28) [x86_64-linux]

-- Machine register context ------------------------------------------------
 RIP: 0x00007f502bd0ca2c RBP: 0x00007ffdf5653fd0 RSP: 0x00007ffdf5653ed8
 RAX: 0x00007f502bd0ca2c RBX: 0x00007f502bde4000 RCX: 0x0000000000000000
 RDX: 0x0000000000000000 RDI: 0x00007f502bde3010 RSI: 0x0000000000000001
  R8: 0x0000000000000000  R9: 0x00007f502bc4b7c8 R10: 0x00007f502bde3000
 R11: 0x0000000000000206 R12: 0x00007f502bde2c40 R13: 0x00007ffdf5653f28
 R14: 0x00007f502c1fa008 R15: 0x00000000ffffffff EFL: 0x0000000000010202

-- C level backtrace information -------------------------------------------
Bus error

this is on WSL2 with docker desktop edge with WSL2 support.

@LucioFranco
Copy link
Contributor

Update: Both @a-rodin and I finally got this running locally. We both had it passing which tells me the CI machines are just being too slow. The test is correct and everything passes on a larger machine.

@LucioFranco
Copy link
Contributor

Going to close this issue since technically the test passes and the larger time we applied has seemed to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: buffers Anything related to Vector's memory/disk buffers domain: tests Anything related to Vector's internal tests type: bug A code related bug.
Projects
None yet
Development

No branches or pull requests

2 participants