-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): Improve vector generate
syntax and formatting
#1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashley Jeffs <ash@jeffail.uk>
Signed-off-by: Ashley Jeffs <ash@jeffail.uk>
Hoverbear
reviewed
Feb 11, 2020
@Jeffail Are docs updates coming in another PR? |
Looks so much better! $ cargo run -- generate stdin,kafka/add_fields,remove_fields,json_parser,json_parser/console
Finished dev [unoptimized + debuginfo] target(s) in 0.14s
Running `target/debug/vector generate stdin,kafka/add_fields,remove_fields,json_parser,json_parser/console`
data_dir = "/var/lib/vector/"
dns_servers = []
[sources.source0]
max_length = 102400
type = "stdin"
[sources.source1]
type = "kafka"
[transforms.transform0]
inputs = ["source0", "source1"]
type = "add_fields"
[transforms.transform1]
inputs = ["transform0"]
type = "remove_fields"
[transforms.transform2]
inputs = ["transform1"]
drop_field = true
drop_invalid = false
type = "json_parser"
[transforms.transform3]
inputs = ["transform2"]
drop_field = true
drop_invalid = false
type = "json_parser"
[sinks.sink0]
healthcheck = true
inputs = ["transform3"]
type = "console"
[sinks.sink0.buffer]
type = "memory"
max_events = 500
when_full = "block" |
Not for this one, not sure there's any mention of |
Ok! :) |
Signed-off-by: Ashley Jeffs <ash@jeffail.uk>
Hoverbear
approved these changes
Feb 11, 2020
bednar
pushed a commit
to bonitoo-io/vector
that referenced
this pull request
Feb 17, 2020
…dev#1773) * Explicitly add spacing between component types Signed-off-by: Ashley Jeffs <ash@jeffail.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the
vector generate
syntax to allow forward slashes:foo/bar,baz/boo
, closing #1684. This is backwards compatible as the pipe syntax can still be used.The output now also adds empty lines between component types to make the formatting nicer:
This is the lowest hanging fruit of #1685, we're still missing:
inputs
first, followed bytype
, and so on)But this stuff would require a fair amount of time investment, and I'd like to have a plan/spec for #1735 before we go ahead with it. I'll update #1685 accordingly.