-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(internal_metrics source): Instrument few more components with metrics #2620
Conversation
Signed-off-by: Alex Gavrisco <alexandr@gavrisco.com>
Signed-off-by: Alex Gavrisco <alexandr@gavrisco.com>
Signed-off-by: Alex Gavrisco <alexandr@gavrisco.com>
Signed-off-by: Alex Gavrisco <alexandr@gavrisco.com>
Signed-off-by: Alex Gavrisco <alexandr@gavrisco.com>
Signed-off-by: Alex Gavrisco <alexandr@gavrisco.com>
Signed-off-by: Alex Gavrisco <alexandr@gavrisco.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look great, thanks so much @Alexx-G!
Thanks @Alexx-G! |
Thanks for reviewing it @lukesteensen ! |
…trics (vectordotdev#2620) Signed-off-by: Brian Menges <brian.menges@anaplan.com>
This PR instruments few components with metrics following checklist from #2007
I've followed initial implementation from #1953
I have few open questions though:
ElasticSearchEventReceived
defined forsink
component, however most internal events define*Sent
events for sinks and*Received
events for sources. And since corresponding metric name in most places isevents|bytes_processed
, it's a bit confusing adding metrics for the first time.