-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include internal trace context with internal metrics #2660
Comments
@lukesteensen is this something @ktff could work on? This would require upstream work but I think it might be worth it. |
I've chimed in on metrics-rs/metrics#70 to see if there's anything we can help with. |
@MOZGIII as discussed, I think this is the highest priority change outside of any remaining k8s works. I've added this to your sprint. It might be worth chiming in on metrics-rs/metrics#70 to ensure your approach will be accepted. |
@MOZGIII how's this coming? Just noting this is priority after the source-level line merging. |
I've started with the implementation. |
@MOZGIII Could you explain a bit about what your rough plan is here? I'd like to do as much of this work as possible in the open so that we can make sure we're aligned with the upstream projects. |
To add more context here. We chatted with the maintainer of |
Ah, gotcha. I can follow along in Discord. |
Yep, here's what we're planning to do:
That's about it, roughly. I hope it goes smoothly and without any more surprises. |
A tiny status update:
For further progress, check out the metrics-rs/metrics#87. |
#1953 introduced a new
internal_metrics
source for Vector's internal metrics. Metrics are defined within events, you can see an example here. A caveat noted in #1953 is the ability to carry over the internal tracing context:This issue represents the work to solve this.
The text was updated successfully, but these errors were encountered: